Add RoleARN to NodeGroupSummary #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@errordeveloper, do I have to do anything else to get this pull request merged into master? |
|
@martina-if could you review this pull request? |
|
Hi @t0rr3sp3dr0 , Thanks for your contribution! Adding the instance role makes sense but the instance profile is not something I've seen requested that much. You could also get it by knowing the instance role. Can you remove that part? By the way, we also have this issue if you are interested: #585 From there eksctl could expose more details from the stacks and in a more organized way. |
t0rr3sp3dr0
changed the title
Signed-off-by: Pedro Tôrres <[email protected]>
|
@martina-if I've removed instance profile from the code and its tests. About the issue you mentioned, I'll take a look on that! |
martina-if
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add possibility to get Instance Role ARN from
eksctl get nodegroupon YAML and JSON outputs.Checklist
README.md, andexamplesdirectory)