Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license: document files under MPL-2 and CDDL #141

Merged
merged 1 commit into from
Aug 9, 2018
Merged

license: document files under MPL-2 and CDDL #141

merged 1 commit into from
Aug 9, 2018

Conversation

dholbach
Copy link
Contributor

No description provided.

@errordeveloper
Copy link
Contributor

I believe there are license files already in vendor/, maybe you can simply point at those instead of adding new copies? Also, I don't think we actually use the code as such.

@dholbach
Copy link
Contributor Author

I'm trying to follow the instructions on https://www.apache.org/legal/resolved.html#category-b - sorry for not pointing this out in the PR description.

LICENSE.MPL-2.0 Outdated
eksctl makes use of the following pieces of code which are licensed under
the MPL-2.0:

https://github.com/go-sql-driver/mysql

This comment was marked as abuse.

LICENSE.MPL-2.0 Outdated

At the point of writing they also pull in

https://github.com/hashicorp/hcl

This comment was marked as abuse.

LICENSE.CDDL Outdated
eksctl makes use of code which in turn pull in code under the CDDL.
At the point of writing this is:

https://github.com/howeyc/gopass

This comment was marked as abuse.

@errordeveloper
Copy link
Contributor

So you are saying that APL guideline dictate this convention of having LICENSE.<TYPE> in top-level directory?

@dholbach
Copy link
Contributor Author

I'm happy to call the license file whatever we want - I just wanted to make them distinguishable.

https://www.apache.org/legal/resolved.html#category-b says:
"By attaching an appropriate and prominent label to the distribution, and requiring an explicit action by the user to get the reciprocally-licensed source, users are less likely to be unaware of restrictions significantly different from those of the Apache License. Please include the URL to the product's homepage in the prominent label. An appropriate and prominent label is a label the user will read while learning about the distribution - for example in a README. Please also ensure to comply with any attribution/notice requirements in the specific license in question."

So we could add it to README too.

@dholbach
Copy link
Contributor Author

dholbach commented Aug 2, 2018

I updated the PR and it reflects current vendoring reality.

If you prefer, I could re-do the PR to add a brief section to README.md about licenses. It's what is suggested on the Apache Legal site.

hcl includes a copy of the MPL-2.0 license, so just pointing to that should be fine AFAIUI.

gopass includes terminal_solaris.go which is under CDDL-1.0, but it just contains a brief bit in the header, not the full license text. §3.1 of the license seems to require this though.

LMK what you think.

errordeveloper
errordeveloper previously approved these changes Aug 9, 2018
@dholbach
Copy link
Contributor Author

dholbach commented Aug 9, 2018

Sorry, please review again - basically I just "updated the branch" locally. Did another review of the source, it's fine right now (7701fdc).

@dholbach dholbach merged commit a9f6b81 into eksctl-io:master Aug 9, 2018
@dholbach dholbach deleted the licenses-fix branch August 9, 2018 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants