Update authenticator name when checking its existence #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/utils/utils.go
Outdated
| return nil | ||
| } | ||
| } | ||
| return fmt.Errorf("aws-iam-authenticator not installed") |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -46,16 +45,6 @@ func CheckKubectlVersion(env []string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func CheckHeptioAuthenticatorAWS() error { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
pkg/utils/utils.go
Outdated
|
|
||
| // CheckHeptioAuthenticatorAWS checks for the authenticator binary existence. | ||
| // DEPRECATED: Use CheckAuthenticatorBinary | ||
| func CheckHeptioAuthenticatorAWS() error { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
pkg/utils/utils.go
Outdated
| } | ||
|
|
||
| // CheckAuthenticatorBinary checks for the authenticator binary existence. | ||
| func CheckAuthenticatorBinary() error { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Did you think about plug this all the way to |
qustavo
force-pushed
the
authenticator-binary
branch
from
b94765c to
615a7d3
Compare
pkg/utils/kubectl.go
Outdated
| return nil | ||
| } | ||
| } | ||
| return fmt.Errorf("Neither aws-iam-authenticator nor heptio-authenticator-aws are installed") |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
qustavo
force-pushed
the
authenticator-binary
branch
from
615a7d3 to
1497aca
Compare
Also added some cosmetic changes: Moved the function from kubectl.go to utils.go given that the binary checking is not related to kubectl And update the function name from CheckHeptioAuthenticatorAWS to a more generic one.
errordeveloper
approved these changes
Aug 6, 2018
|
Let's do it in a separate PR |
martina-if
added a commit
to martina-if/eksctl
that referenced
this pull request
Jan 31, 2020
Adding feature 6
torredil
pushed a commit
to torredil/eksctl
that referenced
this pull request
May 20, 2022
Add SECURITY_CONTACTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some cosmetic changes:
Moved the function from kubectl.go to utils.go given that the binary
checking is not related to kubectl
And update the function name from CheckHeptioAuthenticatorAWS to a more
generic one.
Closes #112