Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable EC2 auto scaling group metric collection #827

Closed
voxxit opened this issue May 30, 2019 · 2 comments · Fixed by #2055
Closed

Enable/disable EC2 auto scaling group metric collection #827

voxxit opened this issue May 30, 2019 · 2 comments · Fixed by #2055
Labels
area/nodegroup kind/feature New feature or request

Comments

@voxxit
Copy link

voxxit commented May 30, 2019

Why do you want this feature?
As a cluster administrator, I want to be able to enable group metrics collection on my EC2 auto scaling groups created via eksctl node groups so that I can keep track of scale-up/scale-down activity, min/max node group sizes over time, etc.

What feature/behavior/change do you want?
See: https://docs.aws.amazon.com/cli/latest/reference/autoscaling/enable-metrics-collection.html

@voxxit voxxit added the kind/feature New feature or request label May 30, 2019
@errordeveloper
Copy link
Contributor

This is possible to do in CloudFormation: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-as-group.html#aws-properties-as-group--examples

I would guess we'd just add nodegroup property called something like asgMetricsCollection. As with other CloudWatch-based things, we should keep off by default. With respect to field values, granularity should be expressed in Kubernetes-native units as well as AWS-native i.e. 1m and 1Minute should be valid. Other than that, it sounds like a fairly simple feature.

@setevoy2
Copy link

Jun 4, 2019

Hi!
Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/nodegroup kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants