Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing the Git private SSH key via its filepath is not GitOps friendly #1533

Closed
marccarre opened this issue Nov 7, 2019 · 1 comment
Closed
Labels
area/config-file area/gitops gitops related issues kind/feature New feature or request priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases

Comments

@marccarre
Copy link
Contributor

Problem

Currently, we accept --git-private-ssh-key-path and will soon have the equivalent in ClusterConfig. However, this will not work well with a cluster-level GitOps approach, as the file path only is meaningful for the local machine.

Solution

Instead, we should refer a key in a Kubernetes Secret or in AWS, e.g.:

  1. register the SSH key in AWS:
    eksctl create keypair $keyName --from-file /path/to/private/ssh/key/file/id_rsa
  2. run eksctl enable repo the following way:
    eksctl enable repo --git-private-ssh-key-name $keyName
    or
    eksctl enable repo -f /path/to/clusterconfig.yaml
    having $keyName present in there.

See also #1211, #1273

@marccarre marccarre added kind/feature New feature or request area/config-file area/gitops gitops related issues labels Nov 7, 2019
@martina-if martina-if added the priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases label Sep 15, 2020
@Callisto13
Copy link
Contributor

Closing due to #2963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config-file area/gitops gitops related issues kind/feature New feature or request priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases
Projects
None yet
Development

No branches or pull requests

3 participants