Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use own private key with eksctl install flux #1448

Closed
cw-sakamoto opened this issue Oct 15, 2019 · 3 comments
Closed

Use own private key with eksctl install flux #1448

cw-sakamoto opened this issue Oct 15, 2019 · 3 comments
Labels
kind/feature New feature or request

Comments

@cw-sakamoto
Copy link
Contributor

Why do you want this feature?

  • We want to use own private key with eksctl install flux
    • To skip the step of registering the new key created by eksctl install flux

What feature/behavior/change do you want?

  • We want the key specified in git-private-ssh-key-path to be secrets.
@cw-sakamoto cw-sakamoto added the kind/feature New feature or request label Oct 15, 2019
@marccarre
Copy link
Contributor

@cw-sakamoto, do you mean you would like to re-use a pre-existing Kubernetes Secret containing your private SSH key? If so, it should just work w/o providing anything via --git-private-ssh-key-path as we already check for the existence of the Flux Secret here: https://github.com/weaveworks/eksctl/blob/2fe768da7cb91c5cde630c4ea1ef729038672954/pkg/gitops/flux/installer.go#L301-L313

Also, FYI, for various reasons, we've been thinking of removing --git-private-ssh-key-path and having instead the user flow described in #1533. Would this help in any way?

@cw-sakamoto
Copy link
Contributor Author

cw-sakamoto commented Nov 8, 2019

@marccarre Thanks for your comment!
When I tried with 0.6.0, I felt that the secrets I created by this document were deleted, but I might have misunderstood.
When I checked again with the latest 0.8.0, the secrets were not deleted and remained..😀

This ticket will be closed as we can use own private key in any way.

I think #1533 is also very good! Operations can be easily understood if unified with the eksctl not kubectl

@marccarre
Copy link
Contributor

@cw-sakamoto, glad it is working for you now! 🙂👍
For reference, the behaviour you needed was introduced in #1225, in particular:

Also note that the Secret for Flux's private SSH key isn't changed, in order to avoid the user having to reconfigure Flux access to their repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants