Skip to content

Commit

Permalink
Deprecate 1.13
Browse files Browse the repository at this point in the history
Export kube resources from 1.16 cluster to sample-1.16.json
  • Loading branch information
sayboras committed May 6, 2020
1 parent fa87161 commit fd7e3ae
Show file tree
Hide file tree
Showing 6 changed files with 161 additions and 114 deletions.
4 changes: 2 additions & 2 deletions docs/proposal-005-upgrades.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ It should be possible to provide simple command under utils for each of these.
At the time of writing of this proposal version downgrades were not supported by EKS.
It's trusted that upgrades will work as expected with EKS SLA.

More specifically, an `eks.UpdateClusterVersion` call for cluster running 1.13+ trying
to go back to 1.10, 1.11 or 1.12 results in the following error:
More specifically, an `eks.UpdateClusterVersion` call for cluster running 1.14+ trying
to go back to 1.10, 1.11, 1.12 or 1.13 results in the following error:
```
An error occurred (InvalidParameterException) when calling the UpdateClusterVersion operation: unsupported Kubernetes version update from the current version, 1.12 to 1.10
```
Expand Down
55 changes: 0 additions & 55 deletions pkg/addons/default/coredns_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,61 +73,6 @@ var _ = Describe("default addons - coredns", func() {
})
}

loadSampleAndCheck("1.12", "1.2.2")

Context("[1.12 –> 1.13] can update coredns", func() {

loadSample("1.12", 10)

It("can load 1.12 sample", func() {
checkCoreDNSImage(rawClient, "eu-west-1", "v1.2.2", true)
})

It("detects coredns version match local vs cluster", func() {
needsUpdate, err := UpdateCoreDNS(rawClient, "eu-west-2", "1.13.x", true)
Expect(err).ToNot(HaveOccurred())
Expect(needsUpdate).To(BeTrue())
})

It("can update to correct version", func() {
_, err := UpdateCoreDNS(rawClient, "eu-west-2", "1.13.x", false)
Expect(err).ToNot(HaveOccurred())
checkCoreDNSImage(rawClient, "eu-west-2", "v1.2.6", false)

createReqs := []string{
"POST [/clusterrolebindings] (aws-node)",
"POST [/namespaces/kube-system/serviceaccounts] (coredns)",
"POST [/namespaces/kube-system/configmaps] (coredns)",
"POST [/namespaces/kube-system/services] (kube-dns)",
"POST [/namespaces/kube-system/daemonsets] (aws-node)",
"POST [/clusterroles] (system:coredns)",
"POST [/clusterrolebindings] (system:coredns)",
"POST [/namespaces/kube-system/deployments] (coredns)",
"POST [/namespaces/kube-system/daemonsets] (kube-proxy)",
"POST [/clusterroles] (aws-node)",
}

Expect(rawClient.Collection.Created()).To(HaveLen(len(createReqs)))
for _, k := range createReqs {
Expect(rawClient.Collection.Created()).To(HaveKey(k))
}

updateReqs := []string{
"PUT [/namespaces/kube-system/serviceaccounts/coredns] (coredns)",
"PUT [/namespaces/kube-system/configmaps/coredns] (coredns)",
"PUT [/namespaces/kube-system/services/kube-dns] (kube-dns)",
"PUT [/clusterroles/system:coredns] (system:coredns)",
"PUT [/clusterrolebindings/system:coredns] (system:coredns)",
"PUT [/namespaces/kube-system/deployments/coredns] (coredns)",
}

Expect(rawClient.Collection.Updated()).To(HaveLen(len(updateReqs)))
for _, k := range updateReqs {
Expect(rawClient.Collection.Updated()).To(HaveKey(k))
}
})
})

loadSampleAndCheck("1.13", "1.2.6")

Context("[1.13 –> 1.14] can update coredns", func() {
Expand Down
Loading

0 comments on commit fd7e3ae

Please sign in to comment.