Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to run all tests for Dotty, one fails #92

Merged
merged 5 commits into from
Oct 16, 2020
Merged

Update to run all tests for Dotty, one fails #92

merged 5 commits into from
Oct 16, 2020

Conversation

ekrich
Copy link
Owner

@ekrich ekrich commented Sep 2, 2020

No description provided.

@ekrich
Copy link
Owner Author

ekrich commented Sep 16, 2020

Eric K Richardson
@ekrich
Sep 02 09:08
@havocp Do you know offhand if SimpleConfigOrigin should be Serializable? I have a test failing with Dotty, ValidationTest.validationFailedSerializable.
Havoc Pennington
@havocp
Sep 04 09:35
I don't really remember the details but in a quick glance this comment looks relevant https://github.com/lightbend/config/blob/e0984d41b040d64b650c7014108a7db9dd451457/config/src/main/java/com/typesafe/config/ConfigException.java#L53-L59

@ekrich ekrich mentioned this pull request Sep 16, 2020
Closed
9 tasks
@ekrich ekrich force-pushed the topic/dotty-tests branch from 64d9107 to 96ae57b Compare October 15, 2020 18:28
@ekrich ekrich force-pushed the topic/dotty-tests branch from 96ae57b to 8c9fe0c Compare October 16, 2020 16:48
@ekrich ekrich merged commit 85695a0 into master Oct 16, 2020
@ekrich ekrich deleted the topic/dotty-tests branch October 16, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ekrich