This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
Small changes to make plugin work with sf3 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,6 +9,7 @@ This is the Ekino Wordpress plugin to interact with Symfony. | |||
| 1) Put the following lines at the beginning of your `wp-config.php` file, according to your project configuration: | |||
|
|
|||
| ```php | |||
| define('WP_SYMFONY_VERSION', 3.0); | |||
There was a problem hiding this comment.
There is no need to use a constant. Just use the constant version defined in the Kernel class.
|
@rande Thanks for the suggestion, much cleaner! |
|
@bassim Can you squash your commit ? Thanks |
…ON before autoloading
|
@rande I have to some more require_once's before I can evaluate AppKernel::MAJOR_VERSION actually, see: |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With backward compatibility