Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup npm package #138

Merged
merged 6 commits into from
May 13, 2017
Merged

Setup npm package #138

merged 6 commits into from
May 13, 2017

Conversation

bartvanandel
Copy link
Contributor

I've put some effort into turning this nice tool into an npm package. I've just published and tested it, works like a charm! Would you consider pulling the changes into master?

NB: I've added myself as a contributor for this, but I've set up the package to point to the original (your) github page, assuming you'd agree. If this is not desired, please let me know and I'll change it. If you'd like to be able to push to npm yourself, let me know as well so I can set this up.

@adam-waldenberg
Copy link
Member

Hi @bartvanandel. Yes, we can add it to master. I personally don't use npm regularly , so it's better somebody else handles it. If you like, I can add you as the maintainer of this part.

@bartvanandel
Copy link
Contributor Author

@adam-waldenberg, that sounds fine to me.

Note that I may have to update the package version number if a new npm release is required, at least in package.json. I'll try to keep those changes to a minimum.

@bartvanandel
Copy link
Contributor Author

Any news about this pull request?

@adam-waldenberg
Copy link
Member

adam-waldenberg commented Jan 6, 2017

Hi @bartvanandel . Will get to it as soon as I get time. In the future, I'll make sure to modify package.json when a new version is branhced. I'm planing a 0.4.5 release next. I'll let you handle the publishing when new versions get released.

@bartvanandel
Copy link
Contributor Author

Okay, thanks, please inform me when the time is ripe.

@bartvanandel
Copy link
Contributor Author

Changed a few things a few minutes ago.

@adam-waldenberg adam-waldenberg merged commit 40cfd0a into ejwa:master May 13, 2017
@adam-waldenberg
Copy link
Member

@bartvanandel Officially merged in master. I'll let you know when I have 0.4.5 ready. I'm planning to have it ready for release relatively soon.

@adam-waldenberg adam-waldenberg added this to the 0.4.5 milestone May 13, 2017
@bartvanandel bartvanandel deleted the npm-package branch May 14, 2017 10:57
@adam-waldenberg adam-waldenberg modified the milestones: 0.4.5, 0.5.0 Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants