Publish directory and recursive settings unexpected behavior

[ejhayes]

Fixes #65 #104

differing readdir behavior

It appears that the recursive param of readdir differs between local development (mac in my case) and github actions

Local (mac)

$ mkdir -p test1/d0/d1
$ node -e "const readdir = require('fs/promises').readdir; readdir('test1',{recursive: true}).then((res) => console.log(res))"
[ 'd0' ]

GitHub actions:

$ mkdir -p test1/d0/d1
$ node -e "const readdir = require('fs/promises').readdir; readdir('test1',{recursive: true}).then((res) => console.log(res))"
[ 'd0', 'd0/d1' ]

Possibly related to?

• fs#readdir(Sync) breaks when recursive + withFileTypes combined nodejs/node#48858
• fs.readdir - option depth nodejs/node#49243

When used without the recursive option readdir will only read directories from the top level in both environments.

Incorrect getChartDirs result for nonrecursive config

When recursive set to false the returned value of getChartDirs was a string instead of an array. This caused subsequent iteration to be against a string instead of array

No such file for destPath

Iterating over charts was being done against srcPath instead of destPath. This resulted in a cryptic seeming error message like this:

[Error: ENOENT: no such file or directory, scandir 'publish/templates'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'scandir',
  path: 'publish/templates'
}

The code in this package was doing something that amounted to this:

cp -r myChartPath myDestPath
ls -l myDestPath/myChartPath

In the above case, there would be no myChartPath under myDestPath, only the contents of myChartPath

Version

Published prerelease version: v0.1.4-next.1

Changelog

🎉 This release contains work from a new contributor! 🎉

Thank you, Rohit Khattar (@rfun), for all your work!

🐛 Bug Fix

• Publish directory and recursive settings unexpected behavior #105 (@rfun @ejhayes)
• Fix reading recurive dirs #65 (@rfun)

🔩 Dependency Updates

• Bump actions/checkout from 3 to 4 #72 (@dependabot[bot])

Authors: 3

• @dependabot[bot]
• Eric Hayes (@ejhayes)
• Rohit Khattar (@rfun)

[github-actions]

🚀 PR was released in v0.1.4 🚀