[fleche] Cache document creation #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't seem useful anymore.
Some clients, such as Visual Studio Code, may open / close buffers aggressively when working, this creates some extra load as we don't cache document creation. This PR does cache it. In general this has a very low footprint on memory by itself, as the root state is shared across all buffers, but of course, the documents themselves could be a big load, but that's already the case so we don't make things worse. Fixes #363 [Test suite passes ;)]
ejgallego
added
kind: enhancement
Alizter
reviewed
Feb 18, 2023
| @@ -22,7 +22,7 @@ let memo_cache_file = ".coq-lsp.cache" | |||
|
|
|||
| let memo_save_to_disk () = | |||
| try | |||
| Fleche.Memo.save_to_disk ~file:memo_cache_file; | |||
| (* Fleche.Memo.save_to_disk ~file:memo_cache_file; *) | |||
There was a problem hiding this comment.
Did you mean to comment these out?
There was a problem hiding this comment.
Yes, the stuff in Memo was really dead code so I've removed it, I'd like to keep these ones as stubs for now tho.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients, such as Visual Studio Code, may open / close buffers
aggressively when working, this creates some extra load as we don't
cache document creation.
This PR does cache it. In general this has a very low footprint on
memory by itself, as the root state is shared across all buffers, but
of course, the documents themselves could be a big load, but that's
already the case so we don't make things worse.
Fixes #363
[Test suite passes ;)]