[code] Fix focus race when a Coq file is in column 2

Continuation / fix of #722, #725
ejgallego · Jun 5, 2024 · 9a654ee · 9a654ee
1 parent 899f479
commit 9a654ee
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -17,6 +17,8 @@
  - [nix] Add `pet-server` deps to flake.nix (Léo Stefanesco, #754)
  - [coq-lsp] Fix crash on `--help` option (Léo Stefanesco, @ejgallego,
    #754)
+ - [vscode] Fix focus race when a Coq file is in column 2 (@ejgallego,
+   #755, cc: #722, #725)
 
 # coq-lsp 0.1.10: Hasta el 40 de Mayo _en effect_...
 ----------------------------------------------------

diff --git a/editor/code/src/goals.ts b/editor/code/src/goals.ts
@@ -104,7 +104,11 @@ export class InfoPanel {
       this.panelFactory();
     } else {
       if (!this.panel.visible) {
-        this.panel.reveal(2, true);
+        // Otherwise we create a race with the active editor!
+        // Careful about this.
+        if (window.activeTextEditor?.viewColumn !== 2) {
+          this.panel.reveal(2, true);
+        }
       }
     }
   }