Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maven-checkstyle hook missing #6

Closed
Dome91 opened this issue Sep 21, 2021 · 7 comments
Closed

maven-checkstyle hook missing #6

Dome91 opened this issue Sep 21, 2021 · 7 comments
Assignees

Comments

@Dome91
Copy link

Dome91 commented Sep 21, 2021

Since we updated to v0.3.1, precommit complains that the maven-checkstyle hook is missing.
Was it accidentally removed or was this a conscious decision?

@Dome91 Dome91 changed the title maven-checkstyle hook maven-checkstyle hook missing Sep 21, 2021
@ejba
Copy link
Owner

ejba commented Sep 21, 2021

It was accident.

Thanks for reporting it.

@ejba
Copy link
Owner

ejba commented Sep 21, 2021

I did a new release, v0.3.2, to include the missing hook. Thanks once again.

@ejba ejba self-assigned this Sep 21, 2021
@Dome91
Copy link
Author

Dome91 commented Sep 21, 2021

Thank you very much for the quick response!
But are you sure you included the hook in the newest release? Still having the problem with v0.3.2. There also seems that nothing was committed between release v0.3.1 and v0.3.2

ejba added a commit that referenced this issue Sep 21, 2021
@ejba
Copy link
Owner

ejba commented Sep 21, 2021

Yes, you are right. My bad.

@ejba
Copy link
Owner

ejba commented Sep 21, 2021

@Dome91 Do you still have the problem?

@Dome91
Copy link
Author

Dome91 commented Sep 22, 2021

After executing pre-commit clean and pre-commit install, everything works fine again. Thank you for solving this issue so quickly!

@Dome91 Dome91 closed this as completed Sep 22, 2021
@ejba
Copy link
Owner

ejba commented Sep 22, 2021

I am the one that has to say thanks here for reporting the issue! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants