-
Notifications
You must be signed in to change notification settings - Fork 34
hotsapi.net upload support #162
base: develop
Are you sure you want to change the base?
Conversation
Note that right now duplicate detection does not works ; see hotsapi/hotsapi#38 |
Duplicate detection is now working |
We currently aren't supporting multiple provider(the API does, but the application design doesn't). In the future, we do intend to solve this, but this pull request cannot be included before that. |
Do you mean GUI or architecture? |
Both. I do wish to get support for multiple providers in, but I do want to do it in a way every provider can be toggled. One thing I have been working on is a configuration panel, which would allow us to do that. GUI design-wise, we'd also need to fiddle with the list, such as displaying icons for targets a replay has been uploaded to before it's fully uploaded and removed from the list. This shouldn't be too complex, but the former issue needs to be resolved first. |
@eivindveg thinking about helping with the integration and other necessary related tasks. Whats your vision for the UI/Settings panel? |
I appreciate any help with the design/layout of the settings panel. I'd like to design the internal settings engine myself before it's reviewed. |
We will be integrating this pull request in 2.2 along with multi-provider support. Keep in mind that this will result in conflicts for this pull request which will have to be resolved. To make this easier, please prepare the following information:
|
For hotsapi:
|
@eivindveg curious if you've moved ahead with multi-provider support? Working on macOS support for Hotsapi.Uploader (hotsapi/Hotsapi.Uploader#5) and this was linked as a possible solution. |
Upload to hotsapi.net in addition to hotslogs.
Since hotslogs & hotsapi both use the same format for match ID, I could reuse most of the code of HotsLogsProvider and moved the common code to a new class ReplayUtils.