Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

query os.networkInterfaces() everytime #3

Merged
merged 1 commit into from
Apr 9, 2018
Merged

query os.networkInterfaces() everytime #3

merged 1 commit into from
Apr 9, 2018

Conversation

adonespitogo
Copy link
Contributor

Network cable may be plugged and unplugged so call networkInterfaces() to get current network status

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.875% when pulling 2ea5d5a on adonespitogo:master into 540d246 on eiriksm:master.

2 similar comments
@coveralls
Copy link

coveralls commented Apr 9, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 96.875% when pulling 2ea5d5a on adonespitogo:master into 540d246 on eiriksm:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.875% when pulling 2ea5d5a on adonespitogo:master into 540d246 on eiriksm:master.

@eiriksm
Copy link
Owner

eiriksm commented Apr 9, 2018

Good point, looks good! Would be great with a test as well, but I will probably redo the test suite at some point anyway :)

@eiriksm eiriksm merged commit 2d38198 into eiriksm:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adonespitogo @coveralls @eiriksm