Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump spanner client to v1.53.1 #496

Merged
merged 1 commit into from
Dec 5, 2023
Merged

feat: bump spanner client to v1.53.1 #496

merged 1 commit into from
Dec 5, 2023

Conversation

thall
Copy link
Member

@thall thall commented Dec 5, 2023

Previous version includes a potential nil pointer
exception.

See issue and fix for more information.

Previous version includes a potential nil pointer
exception.

See [issue](googleapis/google-cloud-go#9048) and [fix](googleapis/google-cloud-go#9052) for more information.
@thall thall requested a review from odsod as a code owner December 5, 2023 14:21
@thall thall requested a review from a team December 5, 2023 14:21
Copy link

@oscarmuhr oscarmuhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

@thall thall merged commit 610d9f8 into master Dec 5, 2023
1 check passed
@thall thall deleted the bump-spanner branch December 5, 2023 14:24
@codecov-commenter
Copy link

Codecov Report

Merging #496 (780a205) into master (762bfd8) will decrease coverage by 1.94%.
Report is 189 commits behind head on master.
The diff coverage is 25.18%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #496      +/-   ##
==========================================
- Coverage   44.66%   42.73%   -1.94%     
==========================================
  Files          21       20       -1     
  Lines        4267     4563     +296     
==========================================
+ Hits         1906     1950      +44     
- Misses       2249     2504     +255     
+ Partials      112      109       -3     
Files Coverage Δ
internal/codegen/databasecodegen/common.go 100.00% <100.00%> (ø)
...nternal/codegen/databasecodegen/readtransaction.go 100.00% <100.00%> (ø)
spanddl/table.go 29.46% <0.00%> (ø)
internal/examples/freightdb/descriptor_gen.go 0.00% <0.00%> (ø)
internal/examples/musicdb/descriptor_gen.go 5.55% <0.00%> (-1.47%) ⬇️
internal/examples/freightdb/database_gen.go 23.28% <41.37%> (+0.07%) ⬆️
internal/examples/musicdb/database_gen.go 17.20% <6.29%> (-3.57%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants