Handle sagepay security key (update acceptNotification() type payment for omnipay 3.0) #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mattwire
commented
Feb 25, 2019
mattwire
commented
- acceptNotification() no longer uses the send() method.
- We need to save the transaction reference before redirecting as it's used (in sagepay) to store the security key for the transaction.
- On handling the IPN we either have to set the security key or transaction reference (per omnipay docs) to validate the IPN.
| $response = $this->gateway->acceptNotification($params); | ||
|
|
||
| $transactionId = $response->getTransactionId(); | ||
| $transactionReference = civicrm_api3('Contribution', 'getvalue', ['id' => $transactionId, 'return' => 'trxn_id']); |
There was a problem hiding this comment.
I think getvalue will return errors where empty - I think here & above it would be safer with some empty handling for other gateways
|
Closing in favour of #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.