Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: update include and exclude type #52

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

chouchouji
Copy link
Contributor

Problem

The version of @rollup/pluginutils is ^5.1.0

image

But the type is not same to @rollup/pluginutils.

image

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (4757185) to head (0156816).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   95.50%   97.65%   +2.14%     
==========================================
  Files           2        2              
  Lines         289      298       +9     
==========================================
+ Hits          276      291      +15     
+ Misses         13        7       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eight04
Copy link
Owner

eight04 commented Nov 15, 2024

Should we import type from pluginutils?

@chouchouji chouchouji changed the title types: correct include and exclude type types: update include and exclude type Nov 15, 2024
@chouchouji
Copy link
Contributor Author

Should we import type from pluginutils?

Thanks for your review. I had updated code.

@chouchouji
Copy link
Contributor Author

I wrote a rollup plugin by typescript. The bundle code link is npm. The index.d.cts type is generated by tsup

image

@chouchouji
Copy link
Contributor Author

Regardless of the commonjs module type, I think we should first correct the types of include and exclude. I had updated the type code. Please review again. Thanks.

@eight04 eight04 merged commit 1637df1 into eight04:master Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants