Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): Always start data sampling of new HEAD immediately #306

Merged
merged 16 commits into from
Jun 24, 2024
Merged

feat(node): Always start data sampling of new HEAD immediately #306

merged 16 commits into from
Jun 24, 2024

Conversation

oblique
Copy link
Member

@oblique oblique commented Jun 19, 2024

No description provided.

@oblique oblique marked this pull request as ready for review June 20, 2024 15:25
@oblique oblique requested review from zvolin and fl0rek June 20, 2024 15:25
zvolin
zvolin approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@zvolin zvolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

node/src/daser.rs Outdated Show resolved Hide resolved
fl0rek
fl0rek reviewed Jun 21, 2024
View reviewed changes
node/src/daser.rs Outdated Show resolved Hide resolved
node/src/daser.rs Show resolved Hide resolved
node/src/daser.rs Outdated Show resolved Hide resolved
node/src/daser.rs Outdated Show resolved Hide resolved
node/src/daser.rs Outdated Show resolved Hide resolved
fl0rek
fl0rek reviewed Jun 21, 2024
View reviewed changes
node/src/daser.rs Outdated Show resolved Hide resolved
node/src/daser.rs Outdated Show resolved Hide resolved
oblique and others added 8 commits June 21, 2024 21:26
@oblique @fl0rek
Update node/src/daser.rs
28f5c51 
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Yiannis Marangos <[email protected]>
@oblique @fl0rek
Update node/src/daser.rs
d0269a8 
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Yiannis Marangos <[email protected]>
@oblique @fl0rek
Update node/src/daser.rs
507bd48 
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Yiannis Marangos <[email protected]>
@oblique @fl0rek
Update node/src/daser.rs
c410676 
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Yiannis Marangos <[email protected]>
@oblique @fl0rek
Update node/src/daser.rs
195b2d6 
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Yiannis Marangos <[email protected]>
@oblique @fl0rek
Update node/src/daser.rs
8264d61 
Co-authored-by: Mikołaj Florkiewicz <[email protected]>
Signed-off-by: Yiannis Marangos <[email protected]>
@oblique
numberring
9ae0986
@oblique
comment indentation
ac25909
@oblique oblique requested review from zvolin and fl0rek June 21, 2024 18:44
fl0rek
fl0rek approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@fl0rek fl0rek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 🎸

@zvolin zvolin merged commit cd2afb1 into eigerco:main Jun 24, 2024
6 checks passed
@zvolin zvolin mentioned this pull request Jun 21, 2024
Closed
@oblique oblique deleted the feat/align-daser branch June 24, 2024 17:18
@zvolin zvolin mentioned this pull request Jul 5, 2024
Closed
@oblique oblique mentioned this pull request Jul 15, 2024
Closed
@zvolin zvolin mentioned this pull request Jul 25, 2024
Closed
@zvolin zvolin mentioned this pull request Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvolin zvolin zvolin approved these changes

@fl0rek fl0rek fl0rek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Lumina
Status: Done
Milestone
Sampling window, javascript APIs and ...
Development

Successfully merging this pull request may close these issues.
3 participants
@oblique @fl0rek @zvolin