[Issue 97] Sensor locations may transmit multiple sensor data types #99
Conversation
|
Merged build finished. Test FAILed. |
…rNet and SensorNetValue events
Refcatored gesture classifier so that it listens on a specified sensor
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
| sensorMap.values.forall(_.length == blockSize), | ||
| "all sensor data locations have a common data length" | ||
| sensorMap.values.forall(_.forall(_.length == blockSize)), | ||
| "all sensor data location points have a common data length" |
There was a problem hiding this comment.
While this is a reasonable assumption now, the number of samples can differ in the future (e.g. switching the watch to a 50 Hz sampling rate).
There was a problem hiding this comment.
Talked with Carl, re-sampling should be done, so that every sensor values are taken at the same frequency. For periods when there is no data (the sensor does not transmit anything), a good central values should be inserted.
There was a problem hiding this comment.
Opened issue 103 (#103) to address the possible sampling frequency difference of sensors.
|
buildme |
SensorNetandSensorNetValueare capable of holding multiple sensor data typesUserExercisesClassifierandExerciseModelactor assumptions in light of these changessbt testThis PR aims at closing issue #97