Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cython v3 compatibility with tests #64

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

BTOdell
Copy link
Collaborator

@BTOdell BTOdell commented Oct 13, 2023

Eigency tests are failing to build.

The compile errors point to filter2 and filter3 function tests. Tests build successfully with Cython 0.29.36 but fail with Cython 3.0.0+. Unknown cause but error messages point to __PYX_STD_MOVE_IF_SUPPORTED macro.

Underlying C++ error message:

error: cannot bind non-const lvalue reference of type ‘RowMajorArrayMap&’ {aka ‘Eigen::Map<Eigen::Array<double, -1, -1, 1> >&’} to an rvalue of type ‘Eigen::Map<Eigen::Array<double, -1, -1, 1> >’

@BTOdell BTOdell added the bug label Oct 13, 2023
@BTOdell BTOdell self-assigned this Oct 13, 2023
@BTOdell BTOdell merged commit 09fbc01 into master Oct 13, 2023
56 checks passed
@BTOdell BTOdell deleted the fix/github-actions-build branch October 13, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant