#80 validate number of closing parenthesis #81
Conversation
| */ | ||
| protected function parseComments() | ||
| protected function parseComments(&$openedParenthesis = 0) |
There was a problem hiding this comment.
Instead of passing by reference (which causes hidden side effects), the method can return the number of parenthesis found. What do you think?
There was a problem hiding this comment.
I was thinking of it, but it looked not obvious for method parseComments to return number of parenthesis.
There was a problem hiding this comment.
And making it protected within Parser class? We can initialize it to 0 outside the loop of the Local or Domain parsers.
Similar side-efectish but more OOP.
WDYT?
There was a problem hiding this comment.
Do you mean to change the $openParenthesis variable to a protected field?
There was a problem hiding this comment.
Yes.
El 5/10/2015 8:01 p. m., "Andrei Sozonov" [email protected]
escribió:
In src/Egulias/EmailValidator/Parser/Parser.php
#81 (comment):*/
- protected function parseComments()
- protected function parseComments(&$openedParenthesis = 0)
Do you mean to change the $openParenthesis variable to a protected field?
—
Reply to this email directly or view it on GitHub
https://github.com/egulias/EmailValidator/pull/81/files#r41175960.
|
If it's alright now, let's proceed with a release. I would like to have those changes in my project. Thanks! |
#80 validate number of closing parenthesis
|
Sorry for the delay. |
|
1.2.10 is out with your changes. |
|
Great! Thanks! |
Fix issue #80.
Checking number of closing parenthesis and compare it with number of parenthesis opened before.