chore: update phpunit 9 => 10 and psalm 4 => 5 #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egulias
reviewed
Jun 13, 2023
| @@ -64,7 +64,7 @@ public function invalidUTF8CharsProvider() | |||
| return $chars; | |||
| } | |||
|
|
|||
| protected function utf8Chr($code_point) | |||
| protected static function utf8Chr($code_point) | |||
There was a problem hiding this comment.
Can you explain the reasoning behind this change please?
There was a problem hiding this comment.
PhpUnit 10 is deprecating data providers that are not static.
sebastianbergmann/phpunit@9caafe2
https://docs.phpunit.de/en/10.0/writing-tests-for-phpunit.html#data-providers
This will trigger warnings in phpunit testruns. Some CI break with warnings.
There was a problem hiding this comment.
This particular change is needed to make the data provider static, that is calling this function.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Element is new in PhpUnit 10.2.
The removed attributes in phpunit.xml.dist are the default ones.