Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around deprecations from doctrine/lexer #367

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

nicolas-grekas
Copy link
Contributor

@nicolas-grekas nicolas-grekas commented May 31, 2023

Version 3 of egulias/email-validator is the latest that works on PHP 7.2, thus it's the version that we use to test Symfony 5.4 on PHP 7.2.

Since we enabled reporting of deprecations from Doctrine, we are flooded with notices triggered by this package, because it relies on the deprecated array-style to read tokens.

This PR fixes it.

A quick merge would be appreciated to remove so many failures on our CI 🙏

And a release would help ppl on 7.2 to not have these deprecations also of course.

@egulias
Copy link
Owner

egulias commented Jun 1, 2023

Thanks for taking the time @nicolas-grekas

On it.

@egulias egulias merged commit e5997fa into egulias:3.x Jun 1, 2023
@nicolas-grekas nicolas-grekas deleted the fix-lexer-deprec branch June 1, 2023 07:36
@nicolas-grekas nicolas-grekas restored the fix-lexer-deprec branch June 1, 2023 07:36
@nicolas-grekas nicolas-grekas deleted the fix-lexer-deprec branch June 1, 2023 07:36
@nicolas-grekas
Copy link
Contributor Author

Thanks for merging quickly 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants