-
-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Lexer 2 compatibility #349
Conversation
855defe
to
8c61729
Compare
include: | ||
- php: '8.1' | ||
deps: lowest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new Job tests with low dependencies. This way, issues like the one I've just fixed can be spotted more easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add lowest
to matrix.deps
should that work for both versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Do you want a deps=lowest job for both PHP versions? I felt like one of those is enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, yes, one is enough.
Hi @derrabus! |
8c61729
to
52d8b6b
Compare
Let's try it. |
Nope. I will work on it, I might need to do multiple test. Will merge and fix it later... in 3.x was working. |
This PR fixes an incompatibility with Lexer 2 due to an unnecessarily overridden property.
More details in the comments below.