Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lexer 2 compatibility #349

Merged
merged 1 commit into from
Jan 2, 2023
Merged

Fix Lexer 2 compatibility #349

merged 1 commit into from
Jan 2, 2023

Conversation

derrabus
Copy link
Contributor

@derrabus derrabus commented Jan 2, 2023

This PR fixes an incompatibility with Lexer 2 due to an unnecessarily overridden property.

More details in the comments below.

@derrabus derrabus force-pushed the bugfix/lexer-2 branch 2 times, most recently from 855defe to 8c61729 Compare January 2, 2023 20:38
Comment on lines +22 to +24
include:
- php: '8.1'
deps: lowest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new Job tests with low dependencies. This way, issues like the one I've just fixed can be spotted more easily.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add lowest to matrix.deps should that work for both versions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Do you want a deps=lowest job for both PHP versions? I felt like one of those is enough.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, yes, one is enough.

@egulias
Copy link
Owner

egulias commented Jan 2, 2023

Hi @derrabus!
Scrutinizer is no longer able to find code coverage. I believe that we need to change .scrutinizer.yml and add file: build/logs/clover.xml could fix it.

@derrabus
Copy link
Contributor Author

derrabus commented Jan 2, 2023

Let's try it.

@egulias
Copy link
Owner

egulias commented Jan 2, 2023

Nope. I will work on it, I might need to do multiple test. Will merge and fix it later... in 3.x was working.

@egulias egulias merged commit 17865e0 into egulias:4.x Jan 2, 2023
@derrabus derrabus deleted the bugfix/lexer-2 branch January 2, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants