Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions #348

Merged
merged 10 commits into from
Jan 2, 2023
Merged

GitHub Actions #348

merged 10 commits into from
Jan 2, 2023

Conversation

driesvints
Copy link
Contributor

@driesvints driesvints commented Dec 30, 2022 •
edited
Loading

This PR adds new GitHub Actions build that will replace the old Travis one. I left comments on the most significant parts I changed below.

driesvints
driesvints commented Dec 30, 2022
View reviewed changes
driesvints
driesvints commented Dec 30, 2022
View reviewed changes
@driesvints driesvints marked this pull request as ready for review December 30, 2022 14:24
@driesvints
Copy link
Contributor Author

@derrabus @egulias this one is ready now. Feel free to ask questions if you have some.

@driesvints driesvints mentioned this pull request Dec 30, 2022
Closed
@driesvints driesvints requested a review from derrabus December 30, 2022 14:38
@derrabus
Copy link
Contributor

Thanks, I like it! I don't know how to connect Coveralls either, though.

@egulias
Copy link
Owner

egulias commented Dec 31, 2022

Coveralls is/was used for code coverage, but that is also embedded into Scrutinizer which can in turn also be configured to add failure condition on coverage reduction.
We can remove coveralls al together, it is not providing value right now.

@driesvints
Copy link
Contributor Author

@egulias I removed it 👍

@egulias egulias merged commit b531a23 into egulias:3.x Jan 2, 2023
@egulias
Copy link
Owner

egulias commented Jan 2, 2023

Thanks so much @driesvints !

@driesvints driesvints deleted the gha branch January 2, 2023 17:26
@driesvints
Copy link
Contributor Author

No worries. We've been using egulias/EmailValidator for a while now so happy to give a bit back 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egulias egulias egulias left review comments

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driesvints @derrabus @egulias