Allow doctrine/lexer 2 #340
Conversation
derrabus
force-pushed
the
improvement/allow-lexer-2
branch
2 times, most recently
from
7b8ed65 to
2686e7d
Compare
src/EmailLexer.php
Outdated
| */ | ||
| public $token; | ||
|
|
||
| /** | ||
| * The next token in the input. | ||
| * | ||
| * @var array{position: int, type: int|null|string, value: int|string}|null | ||
| * @var array|Token |
There was a problem hiding this comment.
changing the type of a public property in a non-internal class is still a BC break.
There was a problem hiding this comment.
It's an inherited BC break. This public property is declared in the Lexer library and apparently just overridden here to make the static analysis happy. As long as you pin Lexer to v1 in your project, the type won't change for you.
derrabus
force-pushed
the
improvement/allow-lexer-2
branch
from
2686e7d to
249ed89
Compare
|
The Travis failure is unrelated and seems to be a hiccup on the build runner. |
Scrutinizer apparently does not understand generics at all. Not sure if I can do anything about it. This part should be well covered by Psalm anyway. |
|
Checking Doctrine Lexer's code, it should work so we can ignore Scrutinizr, which in any case are informational anyway. |
|
@egulias The PR was merged, but somehow one of your later merges seems to have reverted my changes. Was that on purpose? |
|
I merged this one and #343 , I might have resolved incorrectly the conflicts. |
|
I've re-submitted this PR as #345. |
This is a lightweight version of #339 that allows
doctrine/lexer2 to be used while maintaining backwards compatibility.For Symfony's CI, we need this change because EmailValidator currently blocks the installation of
doctrine/annotations2 (which itself depends on Lexer 2).This PR by no means intends to replace #339: #339 is still useful because it fully migrates this project to Lexer's new API. But since it involves BC breaks, I suggest to merge this PR into 3.x and release #339 as v4.