Reimplement DNSCheckValidation #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport for detection of Null MX records (RFC7505) and reserved, mDNS and private namespaces (RFC2606 & RFC6762)
…example.com now (correctly) fails the tests due to the Null MX case
|
Building now, but seems to be failing on PHP 5.5 with "Peer fingerprint did not match". Looks like a Travis CI issue? |
egulias
requested changes
Jul 21, 2020
There was a problem hiding this comment.
Great job @BenHarris , I've made some comments for you to check.
|
Yes, it was Travis, working now. |
BenHarris
commented
Jul 22, 2020
egulias
requested changes
Jul 23, 2020
egulias
requested changes
Jul 25, 2020
|
Should be good to go now. Looks like Travis has failed again though as before. Just a thought, but we should add psalms as a composer dev dependency. |
glensc
reviewed
Aug 6, 2020
glensc
reviewed
Aug 6, 2020
glensc
reviewed
Aug 6, 2020
egulias
approved these changes
Aug 8, 2020
|
Approived. Thanks for your work @BenHarris ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilise get_dns_record and extend support for the detection of Null MX records (RFC7505) and reserved, mDNS and private namespaces (RFC2606 & RFC6762). References #249.
I have had to remove the testDnsWarnings test as I'm not sure of any specific domains which have one or more A/AAAA records, but no MX records, which are not "Null MX" records.