Move files in typical src and tests folder #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Surprisingly psalm throws the same errors in master branch as well so I didn't break it! |
|
Hi @simonschaufi I think it makes sense. |
|
To be honest, I don't understand the error message from psalm. |
|
@egulias would you agree with merging this one and I'll try my best to find a solution in another PR? |
|
I understand the problem is here EmailValidator/src/Parser/Parser.php Line 25 in c8d2ff9 The docblock says that it is an array of "Warning" type, however, the comparission is being done against an int from a constant. I think it needs a dockblock of type "array" instead. Makes sense? |
|
yes, this fixes it! Thank you for your help! |
|
Great news! All green! There we go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.