Le shadow master #139
Merged
Le shadow master #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to RFC2181, every DNS query needs to have a . at the end of the name record you are requesting. This will show that that name record is the root of the domain you are asking In some cases, when the . is missing, the hostname of the server the code is running on will be appended to the name record when checkdnsrr() is being executed and this will in turn return a false positive when there is a wildcard DNS record for the root domain of the hostname of the server.
LeShadow
added a commit
to LeShadow/EmailValidator
that referenced
this pull request
Feb 1, 2017
…also accessible in the 1.2.x releases. This fix allows for more compliance with the DNS RFC. Explanation here: egulias@08bac06
egulias
pushed a commit
that referenced
this pull request
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137