Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme #135

Merged
merged 2 commits into from
Dec 15, 2016
Merged

update readme #135

merged 2 commits into from
Dec 15, 2016

Conversation

gjenjoying
Copy link
Contributor

use Egulias\EmailValidator\Validation\RFCValidation is required.

@gjenjoying
update readme
aa010f0 
use Egulias\EmailValidator\Validation\RFCValidation  is required.
issei-m
issei-m approved these changes Dec 13, 2016
View reviewed changes
Copy link
Contributor

@issei-m issei-m left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

issei-m
issei-m suggested changes Dec 13, 2016
View reviewed changes
Copy link
Contributor

@issei-m issei-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semicolon is missing at EOL.

issei-m
issei-m approved these changes Dec 13, 2016
View reviewed changes
Copy link
Contributor

@issei-m issei-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! LGTM 🍺

@egulias egulias merged commit 181a2fc into egulias:master Dec 15, 2016
@egulias
Copy link
Owner

egulias commented Dec 15, 2016

Thanks both :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@issei-m issei-m issei-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjenjoying @egulias @issei-m