Correct PHP example. Add a requirements section. #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected PHP example for missing semi-colons. Added a new requirements section that explains the need for composer and the need of the PHP Intl library to use the spoof validation.
| @@ -4,6 +4,10 @@ | |||
| With the help of | |||
|
|
|||
|  | |||
|
|
|||
| ##Requirements## | |||
| To load this library, you must have [Composer](https://getcomposer.org) installed and operational. The Spoofchecking validation requires that your PHP system have the [PHP Internationalization Libraries](http://php.net/manual/en/book.intl.php) (also known as PHP Intl) insalled. | |||
There was a problem hiding this comment.
Can you please make it a list?
Also add a link to the Spoof validation or to the list of available validations.
Turned requirements into an unordered list. Removed the PHPstorm logo as it doesn't exist and could not find one to replace it.
|
@egulias Updated. Removed the PHPStorm logo as it was a broken link and I cannot find a replacement. Jetbrains has a link to a zip file of logos on their press page but not the individual image files. |
|
Yeah, I see they've unified all the logos. |
|
|
||
|  |
There was a problem hiding this comment.
At least we can leave the phrase and a link to the PHPStrom page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected PHP example for missing semi-colons. Added a new requirements section that explains the need for composer and the need of the PHP Intl library to use the spoof validation.