New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed some problems in DNSCheckValidation #116

Merged

egulias merged 1 commit into egulias:master from issei-m:fix-dns-validation

Jun 24, 2016

Contributor

issei-m commented Jun 22, 2016 •

edited

Loading

Sorry for opening this topic twice in rapid succession.
However I found more further problems in this class as follows:

The several complex but compliant to RFC email patterns are not supported (e.g. quoted-string local-part)
- As this comment, strict check is not required in here. It means just extracting the domain-part using substr from last @ to the EOL is enough.
upper case email always fails
lack of IPv6 DNS record check (AAAA record)


          fixed some problems in DNSCheckValidation

c1010f4

egulias merged commit 7701238 into egulias:master

issei-m deleted the fix-dns-validation branch

June 25, 2016 05:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet