Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example.co.uk has a valid DNS record now :) #91

Closed
nacc opened this issue Apr 6, 2016 · 3 comments
Closed

example.co.uk has a valid DNS record now :) #91

nacc opened this issue Apr 6, 2016 · 3 comments
Labels
bug v1.2

Comments

@nacc
Copy link

nacc commented Apr 6, 2016

Both Debian & Ubuntu packages of php-email-validator are failing automated tests because example.co.uk no longer issues a DNSWARN_NO_RECORD for getInvalidEmailsWIthWarnings(). Changing it to example3.co.uk passes the tests again, but that seems fragile.
@oerdnj
Copy link

oerdnj commented Apr 6, 2016

You know there's an RFC describing example domains and other for example IP and legacy-IP addresses.
The domain one is here: https://tools.ietf.org/html/rfc6761
Please make sure you use it when crafting tests...

@egulias
Copy link
Owner

egulias commented Apr 25, 2016

Thanks!
I'm rewriting tests for v2, I'll backport them to v1.2 also.

@egulias
Copy link
Owner

egulias commented May 10, 2016

Moved them for v2. I'll close the issue when backported for v1.2

@egulias egulias mentioned this issue May 10, 2016
Merged
egulias added a commit that referenced this issue May 14, 2016
@egulias
Changed invalid dns domains and backslash in domain (#107)
f463fbe 
Fixes #91 and #74 for v1.2.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug v1.2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oerdnj @egulias @nacc