Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using polyfill for ext-intl if #177

Closed
ohartl opened this issue Aug 25, 2018 · 2 comments · Fixed by #190
Closed

Using polyfill for ext-intl if #177

ohartl opened this issue Aug 25, 2018 · 2 comments · Fixed by #190
Assignees
@egulias
Labels
enhancement

Comments

@ohartl
Copy link

ohartl commented Aug 25, 2018

As I stated before in #175 it could be problematic to just disable functionality when the extension is not available on the system. (We had the problem after upgrading from 2.1.4 to 2.1.5.)

Using a polyfill like https://github.com/symfony/polyfill-intl-icu could make this package work out of the box and still use the original functions from ext-intl if available. The suggestion for ext-intl in the composer.json should of course be kept.

The question is wether or not the polyfill from above or another one would make the code work.

For example the package symfony/intl does the same, see https://github.com/symfony/intl/blob/master/composer.json
@egulias egulias self-assigned this Aug 27, 2018
SignpostMarv added a commit to SignpostMarv/EmailValidator that referenced this issue Jan 19, 2019
@SignpostMarv
loading in symfony polyfill, partially resolves egulias#177, but Spoo…
c504af2 
…fChecker does not seem to be polyfilled in symfony/polyfill-intl-*
@SignpostMarv SignpostMarv mentioned this issue Jan 19, 2019
Merged
SignpostMarv added a commit to SignpostMarv/EmailValidator that referenced this issue Sep 1, 2019
@SignpostMarv
loading in symfony polyfill, partially resolves egulias#177, but Spoo…
b273c62 
…fChecker does not seem to be polyfilled in symfony/polyfill-intl-*
SignpostMarv added a commit to SignpostMarv/EmailValidator that referenced this issue Dec 30, 2019
@SignpostMarv
loading in symfony polyfill, partially resolves egulias#177, but Spoo…
cb793ad 
…fChecker does not seem to be polyfilled in symfony/polyfill-intl-*
SignpostMarv added a commit to SignpostMarv/EmailValidator that referenced this issue Dec 31, 2019
@SignpostMarv
loading in symfony polyfill, partially resolves egulias#177, but Spoo…
5e911ec 
…fChecker does not seem to be polyfilled in symfony/polyfill-intl-*
@GrahamCampbell GrahamCampbell mentioned this issue Jan 2, 2020
Closed
3 tasks
SignpostMarv added a commit to SignpostMarv/EmailValidator that referenced this issue Jan 6, 2020
@SignpostMarv
loading in symfony polyfill, partially resolves egulias#177, but Spoo…
6258b0f 
…fChecker does not seem to be polyfilled in symfony/polyfill-intl-*
egulias pushed a commit that referenced this issue Jan 20, 2020
@SignpostMarv @egulias
Enabling psalm on php >= 7.1, fixing #125, #168, #169, partially fixing
e834eea 
#177 (#190)

* experimenting with psalm

* loading in symfony polyfill, partially resolves #177, but SpoofChecker does not seem to be polyfilled in symfony/polyfill-intl-*

* removing unused imports, fixes #168 and #169

* not actually used for object storage

* Egulias\Tests\EmailValidator\Validation\SpoofCheckValidationTest::testEmailWithSpoofsIsInvalid fails if extension is not installed

* satisfying psalm

* amending indentation

* disabling psalm on 5.6

* attempting to resolve psalm issue on 7.0 & 7.1

* dropping psalm from 7.0 matrix

* ext-intl removed as per #231

* updating baseline with psalm 3.8.3

* suppressing issue with Spoofchecker not being present, pending resolution of #231

* enable psalm on travis config for php 7.3
@GrahamCampbell
Copy link
Contributor

This issue needs re-opening. Was not fixed by #190. The spoofchecker part of the extension is not pollyfilled, as stated in #231.

@egulias egulias reopened this Jan 21, 2020
@egulias
Copy link
Owner

egulias commented Dec 30, 2020

Closing per @GrahamCampbell comment on Symfony's decision

@egulias egulias closed this as completed Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egulias egulias

Labels
enhancement
Projects
None yet
Milestone
No milestone
3 participants
@egulias @ohartl @GrahamCampbell