Skip to content

Commit

Permalink
changes for new DlMaskFilter objects (flutter#17)
Browse files Browse the repository at this point in the history
  • Loading branch information
flar authored and dnfield committed Apr 27, 2022
1 parent a2f7555 commit e7f9073
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 12 deletions.
19 changes: 11 additions & 8 deletions impeller/display_list/display_list_dispatcher.cc
Original file line number Diff line number Diff line change
Expand Up @@ -120,15 +120,18 @@ void DisplayListDispatcher::setPathEffect(sk_sp<SkPathEffect> effect) {
}

// |flutter::Dispatcher|
void DisplayListDispatcher::setMaskFilter(sk_sp<SkMaskFilter> filter) {
void DisplayListDispatcher::setMaskFilter(const flutter::DlMaskFilter* filter) {
// Needs https://github.com/flutter/flutter/issues/95434
UNIMPLEMENTED;
}

// |flutter::Dispatcher|
void DisplayListDispatcher::setMaskBlurFilter(SkBlurStyle style,
SkScalar sigma) {
UNIMPLEMENTED;
if (filter == nullptr) {
// Reset everything
return;
}
switch (filter->type()) {
case flutter::DlMaskFilter::kBlur:
case flutter::DlMaskFilter::kUnknown:
UNIMPLEMENTED;
break;
}
}

// |flutter::Dispatcher|
Expand Down
5 changes: 1 addition & 4 deletions impeller/display_list/display_list_dispatcher.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,7 @@ class DisplayListDispatcher final : public flutter::Dispatcher {
void setPathEffect(sk_sp<SkPathEffect> effect) override;

// |flutter::Dispatcher|
void setMaskFilter(sk_sp<SkMaskFilter> filter) override;

// |flutter::Dispatcher|
void setMaskBlurFilter(SkBlurStyle style, SkScalar sigma) override;
void setMaskFilter(const flutter::DlMaskFilter* filter) override;

// |flutter::Dispatcher|
void setImageFilter(sk_sp<SkImageFilter> filter) override;
Expand Down

0 comments on commit e7f9073

Please sign in to comment.