Remove dependency on Dart, add crash handler to impellerc (flutter#150)

egramond · Apr 27, 2022 · 8679fe7 · 8679fe7
1 parent 69b676c
commit 8679fe7
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 12 deletions.
diff --git a/impeller/BUILD.gn b/impeller/BUILD.gn
@@ -55,10 +55,6 @@ executable("impeller_unittests") {
     "blobcat:blobcat_unittests",
     "compiler:compiler_unittests",
     "geometry:geometry_unittests",
-
-    # FML depends on the Dart VM for tracing and getting the current
-    # timepoint.
-    "//flutter/runtime:libdart",
   ]
 
   if (impeller_supports_rendering) {

diff --git a/impeller/blobcat/BUILD.gn b/impeller/blobcat/BUILD.gn
@@ -29,10 +29,6 @@ impeller_component("blobcat") {
     ":blobcat_lib",
     "../base",
     "//flutter/fml",
-
-    # FML depends on the Dart VM for tracing and getting the current
-    # timepoint.
-    "//flutter/runtime:libdart",
   ]
 }
 

diff --git a/impeller/compiler/BUILD.gn b/impeller/compiler/BUILD.gn
@@ -44,10 +44,6 @@ impeller_component("impellerc") {
 
   deps = [
     ":compiler_lib",
-
-    # FML depends on the Dart VM for tracing and getting the current
-    # timepoint.
-    "//flutter/runtime:libdart",
   ]
 }
 

diff --git a/impeller/compiler/impellerc_main.cc b/impeller/compiler/impellerc_main.cc
@@ -4,6 +4,7 @@
 
 #include <filesystem>
 
+#include "flutter/fml/backtrace.h"
 #include "flutter/fml/command_line.h"
 #include "flutter/fml/file.h"
 #include "flutter/fml/macros.h"
@@ -18,6 +19,7 @@ namespace impeller {
 namespace compiler {
 
 bool Main(const fml::CommandLine& command_line) {
+  fml::InstallCrashHandler();
   if (command_line.HasOption("help")) {
     Switches::PrintHelp(std::cout);
     return true;