HLM-5926 overriding login page css #702
Conversation
WalkthroughThe recent updates span various components and configurations across the micro UI project. Key changes include CSS adjustments, new parameters for error handling, removal of debugger statements, version updates, and modifications in data paths and input conditions. These changes aim to enhance the UI styling, improve error handling, streamline data access, and ensure compatibility with the latest CSS version. Changes
Poem
Tip Early Access Features
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (12)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/configs/UICustomizations.js (5)
Line range hint
20-26: Consider usingfor...ofinstead offorEachfor better readability and performance.- arr.forEach(obj => { - const value = obj[key]; - if (!uniqueValues.has(value)) { - uniqueValues.add(value); - result.push(obj); - } - }); + for (const obj of arr) { + const value = obj[key]; + if (!uniqueValues.has(value)) { + uniqueValues.add(value); + result.push(obj); + } + }
Line range hint
52-52: Avoid usinghasOwnPropertydirectly from the object; useObject.prototype.hasOwnProperty.call(obj, key)instead to prevent issues with objects that lack a prototype.- if (obj.hasOwnProperty(key)) { + if (Object.prototype.hasOwnProperty.call(obj, key)) {
Line range hint
79-79: Use template literals for string concatenation to improve readability and maintainability.- documentType: action?.action + " DOC", + documentType: `${action?.action} DOC`,Also applies to: 104-104, 129-129, 154-154
Line range hint
205-217: These else clauses can be omitted as the previous branches break early, simplifying the control flow.- else if (moduleCode?.includes("works.wages")) { - return businessServiceMap?.["works.wages"]; - } else if (moduleCode?.includes("works.supervision")) { - return businessServiceMap?.["works.supervision"]; - } else { - return businessServiceMap; - } + else { + return businessServiceMap; + }Also applies to: 222-228
Line range hint
263-268: Simplify the computed expressions by using direct property access instead of using a string literal.- const dropdownData = filterUniqueByKey(data?.MdmsRes?.["HCM-PROJECT-TYPES"]?.projectTypes, "code").map(row => { + const dropdownData = filterUniqueByKey(data.MdmsRes["HCM-PROJECT-TYPES"].projectTypes, "code").map(row => {micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanPreview.js (7)
Line range hint
64-64: Avoid using template literals where not necessary. Use simple strings instead to improve performance.- const tourData = tourSteps(t)?.[page] || {}; + const tourData = tourSteps(t)[page] || {};Also applies to: 289-289, 395-395, 400-400
Line range hint
125-125: Use optional chaining to safely access nested properties.- let microplanPreviewAggregatesList = state?.MicroplanPreviewAggregates; + let microplanPreviewAggregatesList = state?.MicroplanPreviewAggregates?.find((item) => item.campaignType === campaignType)?.data;Also applies to: 658-658, 663-663, 674-674, 676-676
Line range hint
254-254: Declare variables at the root of the enclosing function to avoid hoisting issues.- var { hierarchyLists, hierarchicalData } = processHierarchyAndData(hierarchyRawData, [combinedData]); + let { hierarchyLists, hierarchicalData } = processHierarchyAndData(hierarchyRawData, [combinedData]);
Line range hint
324-324: Use strict inequality (!==) instead of loose inequality (!=) to avoid type coercion errors.- if (dataToShow?.length != 0) { + if (dataToShow?.length !== 0) {
Line range hint
348-348: Avoid redeclaring properties with the same name in object literals.- padding: "1rem", + padding: "0.5rem",Also applies to: 544-544
Line range hint
596-598: Remove unnecessary else clauses to simplify the control flow.- else { - setCheckDataCompletion("perform-action"); - } + setCheckDataCompletion("perform-action");Also applies to: 759-759, 931-933
Line range hint
657-668: Preferfor...ofinstead offorEachfor better performance and readability.- aggregateNameList.forEach((item) => { + for (const item of aggregateNameList) {Also applies to: 804-814
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
micro-ui/web/micro-ui-internals/packages/css/package.jsonis excluded by!**/*.json
Files selected for processing (4)
- micro-ui/web/micro-ui-internals/packages/css/src/components/microplanning.scss (2 hunks)
- micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanPreview.js (2 hunks)
- micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/configs/UICustomizations.js (1 hunks)
- micro-ui/web/public/index.html (1 hunks)
Files skipped from review due to trivial changes (1)
- micro-ui/web/public/index.html
Additional Context Used
Biome (39)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanPreview.js (20)
64-64: Do not use template literals if interpolation and special-character handling are not needed.
125-125: Change to an optional chain.
254-254: This var should be declared at the root of the enclosing function.
289-289: Do not use template literals if interpolation and special-character handling are not needed.
324-324: Use !== instead of !=.
!= is only allowed when comparing againstnull
348-348: This property value named padding is later overwritten by an object member with the same name.
395-395: Template literals are preferred over string concatenation.
400-400: Template literals are preferred over string concatenation.
544-544: This property value named padding is later overwritten by an object member with the same name.
596-598: This else clause can be omitted because previous branches break early.
657-668: Prefer for...of instead of forEach.
658-658: Change to an optional chain.
663-663: Change to an optional chain.
674-674: Change to an optional chain.
676-676: Change to an optional chain.
759-759: This else clause can be omitted because previous branches break early.
804-814: Prefer for...of instead of forEach.
872-872: The computed expression can be simplified without the use of a string literal.
873-873: The computed expression can be simplified without the use of a string literal.
931-933: This else clause can be omitted because previous branches break early.
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/configs/UICustomizations.js (19)
20-26: Prefer for...of instead of forEach.
52-52: Do not access Object.prototype method 'hasOwnProperty' from target object.
79-79: Template literals are preferred over string concatenation.
104-104: Template literals are preferred over string concatenation.
129-129: Template literals are preferred over string concatenation.
154-154: Template literals are preferred over string concatenation.
205-217: This else clause can be omitted because previous branches break early.
207-217: This else clause can be omitted because previous branches break early.
209-217: This else clause can be omitted because previous branches break early.
211-217: This else clause can be omitted because previous branches break early.
213-217: This else clause can be omitted because previous branches break early.
215-217: This else clause can be omitted because previous branches break early.
222-228: This else clause can be omitted because previous branches break early.
224-228: This else clause can be omitted because previous branches break early.
226-228: This else clause can be omitted because previous branches break early.
263-263: The computed expression can be simplified without the use of a string literal.
265-265: The computed expression can be simplified without the use of a string literal.
266-266: The computed expression can be simplified without the use of a string literal.
268-268: The computed expression can be simplified without the use of a string literal.
Path-based Instructions (2)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/configs/UICustomizations.js (1)
Pattern
**/*.js: checkmicro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanPreview.js (1)
Pattern
**/*.js: check
Learnings (1)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanPreview.js (1)
User: siddhant-nawale-egov PR: egovernments/DIGIT-Frontend#606 File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/utils/index.js:276-276 Timestamp: 2024-05-21T07:42:28.329Z Learning: The `addResourcesToFilteredDataToShow` function in `micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/utils/index.js` now includes checks for data integrity, such as validation of `previewData`, the common column, and `resources`, along with error logging for invalid data formats.
Additional comments not posted (2)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanPreview.js (1)
872-872: Simplify the computed expressions by avoiding unnecessary string literals.- setToast({ state: "success", message: t("SUCCESS_DATA_SAVED") }); + setToast({ state: "success", message: t("SUCCESS_DATA_SAVED") });Also applies to: 873-873
Likely invalid or redundant comment.
micro-ui/web/micro-ui-internals/packages/css/src/components/microplanning.scss (1)
2419-2421: Updated font size for.digit-header-contentto2rem.This change aligns with the PR's objective to override CSS for specific components, ensuring that header content is more prominent.
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (7)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/SavedMicroplans.js (1)
Line range hint
163-171: Convert JSX elements without children to self-closing tags.- <InboxSearchComposerV2 - configs={configs} - browserSession={savedMircoplanSession} - additionalConfig={{ - resultsTable: { - onClickRow, - }, - }} - ></InboxSearchComposerV2> + <InboxSearchComposerV2 + configs={configs} + browserSession={savedMircoplanSession} + additionalConfig={{ + resultsTable: { + onClickRow, + }, + }} + />This change adheres to best practices in JSX for elements without children, making the code cleaner and more readable.
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Upload.js (6)
Line range hint
73-73: Consider removing unnecessary template literals for better performance and readability.- const url = `/boundary-service/boundary-hierarchy-definition/_search`; + const url = "/boundary-service/boundary-hierarchy-definition/_search";
Line range hint
142-142: Use optional chaining to prevent potential runtime errors when accessing properties on undefined objects.- campaignData?.hierarchyType + campaignData?.hierarchyType?Also applies to: 199-199, 437-437, 532-532
Line range hint
280-280: Simplify computed expressions to enhance code clarity and maintainability.- const expression = `some complex expression`; + const expression = someSimplifiedVersion;Also applies to: 501-501, 702-702, 730-730, 734-734, 738-738, 740-740, 744-744
Line range hint
330-330: Use strict equality===for comparisons to avoid unexpected type coercion.- if (value == null) + if (value === null)
Line range hint
459-475: ReplaceforEachwithfor...offor better performance and readability in loops.- array.forEach(item => { + for (const item of array) {Also applies to: 737-739
Line range hint
654-659: Remove unnecessaryelseclauses to simplify control flow and enhance readability.- if (condition) { - return x; - } else { - return y; - } + if (condition) { + return x; + } + return y;
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Upload.js (4 hunks)
- micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/SavedMicroplans.js (1 hunks)
Additional Context Used
Biome (21)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Upload.js (20)
73-73: Do not use template literals if interpolation and special-character handling are not needed.
142-142: Change to an optional chain.
199-199: Change to an optional chain.
280-280: The computed expression can be simplified without the use of a string literal.
330-330: Use === instead of ==.
== is only allowed when comparing againstnull
437-437: Change to an optional chain.
459-475: Prefer for...of instead of forEach.
501-501: The computed expression can be simplified without the use of a string literal.
532-532: Change to an optional chain.
654-659: This else clause can be omitted because previous branches break early.
702-702: The computed expression can be simplified without the use of a string literal.
730-730: The computed expression can be simplified without the use of a string literal.
730-730: The computed expression can be simplified without the use of a string literal.
734-734: The computed expression can be simplified without the use of a string literal.
737-739: Prefer for...of instead of forEach.
738-738: The computed expression can be simplified without the use of a string literal.
738-738: The computed expression can be simplified without the use of a string literal.
738-738: The computed expression can be simplified without the use of a string literal.
740-740: The computed expression can be simplified without the use of a string literal.
744-744: The computed expression can be simplified without the use of a string literal.
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/SavedMicroplans.js (1)
163-171: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.
Path-based Instructions (2)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/SavedMicroplans.js (1)
Pattern
**/*.js: checkmicro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Upload.js (1)
Pattern
**/*.js: check
Learnings (1)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Upload.js (2)
User: siddhant-nawale-egov PR: egovernments/DIGIT-Frontend#204 File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:0-0 Timestamp: 2024-03-13T05:11:36.400Z Learning: A more detailed message for file parsing errors in the `Upload.js` file is displayed elsewhere in the code, as clarified by the user.User: siddhant-nawale-egov PR: egovernments/DIGIT-Frontend#204 File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:468-481 Timestamp: 2024-03-13T07:33:45.211Z Learning: The error message in the `checkForErrorInUploadedFile` function within `Upload.js` is being localized and improved for better user experience, as clarified by the user.
Additional comments not posted (3)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/SavedMicroplans.js (1)
93-93: Update thejsonPathto align with the new data structure.This change correctly reflects the updated data path as per the PR objectives.
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Upload.js (2)
826-826: Ensure thecampaignTypeprop is utilized appropriately withinFileUploadComponent.
846-846: Ensure thecampaignTypeprop is utilized appropriately withinUploadedFile.
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range and nitpick comments (25)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Hypothesis.js (5)
Line range hint
29-29: Ensure all dependencies are specified in theuseEffecthook.- }, []); + }, [t, state?.tourStateData?.name, dispatch]);This change ensures that the effect correctly responds to changes in its dependencies.
Line range hint
39-39: Add missing dependencies to theuseEffecthook to ensure correct behavior.- }, []); + }, [currentPage?.id, microplanData, pages, microplanData?.status?.[previouspage?.name], microplanData?.hypothesis.filter]);This ensures that the effect will re-run when any of the specified dependencies change.
Line range hint
53-53: Remove unnecessary dependencies from theuseEffecthook.- }, [campaignType, microplanData, setAutofillHypothesisData, filterHypothesisList, assumptions, setAssumptions]); + }, [campaignType, microplanData]);This change removes dependencies that do not affect the logic within the hook, simplifying the dependency array.
Line range hint
171-171: Avoid overwriting thepaddingproperty in the object.Consider renaming one of the
paddingproperties to avoid confusion and potential bugs.
Line range hint
359-362: Ensure accessibility by adding keyboard event handlers.+ onKeyUp={handleKeyPress}Adding a keyboard event handler will improve accessibility by allowing keyboard navigation.
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanPreview.js (14)
Line range hint
64-64: Consider removing unnecessary template literals for simple strings.- const page = `microplanPreview`; + const page = "microplanPreview";
Line range hint
125-125: Use optional chaining to safely access nested properties.- const joinWithColumns = UIConfiguration.find((item) => item.name === "microplanPreview")?.joinWithColumns; + const joinWithColumns = UIConfiguration?.find((item) => item.name === "microplanPreview")?.joinWithColumns;
Line range hint
254-254: Declare variables at the top of their scope to improve readability and maintainability.- var { hierarchyLists, hierarchicalData } = processHierarchyAndData(hierarchyRawData, [combinedData]); + let hierarchyLists, hierarchicalData; + ({ hierarchyLists, hierarchicalData } = processHierarchyAndData(hierarchyRawData, [combinedData]));
Line range hint
289-289: Avoid using template literals when not interpolating variables or using multi-line strings.- const page = `microplanPreview`; + const page = "microplanPreview";
Line range hint
324-324: Use strict inequality check (!==) instead of loose inequality (!=).- if (dataToShow?.length != 0 || !hierarchyRawData || !hierarchy || validationSchemas?.length === 0) return; + if (dataToShow?.length !== 0 || !hierarchyRawData || !hierarchy || validationSchemas?.length === 0) return;
Line range hint
348-348: Avoid redefining properties in object literals.- padding: 0, + padding: "1rem",
Line range hint
395-395: Prefer template literals over string concatenation for better readability and potential future interpolations.- key={"hyopthesis_" + index} + key={`hyopthesis_${index}`}Also applies to: 400-400
Line range hint
544-544: Avoid redefining properties in object literals.- padding: 0, + padding: "1rem",
Line range hint
596-598: This else clause is redundant and can be omitted for cleaner code.- else setCheckDataCompletion("perform-action");
Line range hint
657-668: Prefer usingfor...offor iterating over arrays for better readability and performance.- filteredSchemas?.map((item) => + for (const item of filteredSchemas) {
Line range hint
658-658: Use optional chaining to safely access nested properties.- const keys = Object.keys(fileData?.data.features[0].properties); + const keys = Object.keys(fileData?.data?.features[0]?.properties);Also applies to: 663-663, 674-674, 676-676
Line range hint
759-759: This else clause is redundant and can be omitted for cleaner code.- else updateData();
Line range hint
804-814: Prefer usingfor...offor iterating over arrays for better readability and performance.- aggregateNameList.forEach((item) => { + for (const item of aggregateNameList) {
Line range hint
931-933: This else clause is redundant and can be omitted for cleaner code.- else updateData();micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Upload.js (6)
Line range hint
73-73: Avoid using template literals when not necessary.Consider replacing the template literal with a regular string or variable reference if no dynamic expressions are embedded.
Line range hint
142-142: Use optional chaining to prevent runtime errors.- if (someObject && someObject.property) + if (someObject?.property)This change ensures that the code does not throw an error if
someObjectis null or undefined.Also applies to: 199-199, 437-437, 532-532
Line range hint
280-280: Simplify computed expressions.Consider simplifying the expression to enhance readability and maintainability.
Also applies to: 501-501, 702-702, 730-730, 734-734, 738-738, 740-740, 744-744
Line range hint
330-330: Use strict equality for comparisons.- if (value == null) + if (value === null)Using
===ensures that both type and value are checked, which is generally safer and prevents unexpected type coercion.
Line range hint
459-475: Preferfor...ofoverforEachfor better performance and readability.- array.forEach((element) => { + for (const element of array) {This change makes the loop easier to understand and debug, especially when using asynchronous operations inside the loop.
Also applies to: 737-739
Line range hint
654-659: Remove unnecessary else clause.- if (condition) { - return x; - } else { - return y; - } + if (condition) { + return x; + } + return y;This simplifies the control flow by removing unnecessary branches.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Hypothesis.js (1 hunks)
- micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanPreview.js (3 hunks)
- micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Upload.js (6 hunks)
Additional Context Used
Biome (60)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Hypothesis.js (20)
45-45: Change to an optional chain.
57-57: Change to an optional chain.
171-171: This property value named padding is later overwritten by an object member with the same name.
359-362: Enforce to have the onClick mouse event with the onKeyUp, the onKeyDown, or the onKeyPress keyboard event.
451-451: Change to an optional chain.
457-457: Change to an optional chain.
29-29: This hook does not specify all of its dependencies: dispatch
29-29: This hook does not specify all of its dependencies: state?.tourStateData?.name
29-29: This hook does not specify all of its dependencies: t
39-39: This hook does not specify all of its dependencies: currentPage?.id
39-39: This hook does not specify all of its dependencies: microplanData.hypothesis
39-39: This hook does not specify all of its dependencies: pages
39-39: This hook does not specify all of its dependencies: pages[currentPage?.id - 1]
39-39: This hook does not specify all of its dependencies: microplanData?.status?.[previouspage?.name]
39-39: This hook does not specify all of its dependencies: microplanData
39-39: This hook does not specify all of its dependencies: microplanData?.hypothesis.filter
53-53: This hook does not specify all of its dependencies: state?.HypothesisAssumptions
53-53: This hook specifies more dependencies than necessary: setAutofillHypothesisData, filterHypothesisList, setAssumptions
54-54: This let declares a variable that is only assigned once.
56-56: This let declares a variable that is only assigned once.
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanPreview.js (20)
64-64: Do not use template literals if interpolation and special-character handling are not needed.
125-125: Change to an optional chain.
254-254: This var should be declared at the root of the enclosing function.
289-289: Do not use template literals if interpolation and special-character handling are not needed.
324-324: Use !== instead of !=.
!= is only allowed when comparing againstnull
348-348: This property value named padding is later overwritten by an object member with the same name.
395-395: Template literals are preferred over string concatenation.
400-400: Template literals are preferred over string concatenation.
544-544: This property value named padding is later overwritten by an object member with the same name.
596-598: This else clause can be omitted because previous branches break early.
657-668: Prefer for...of instead of forEach.
658-658: Change to an optional chain.
663-663: Change to an optional chain.
674-674: Change to an optional chain.
676-676: Change to an optional chain.
759-759: This else clause can be omitted because previous branches break early.
804-814: Prefer for...of instead of forEach.
872-872: The computed expression can be simplified without the use of a string literal.
873-873: The computed expression can be simplified without the use of a string literal.
931-933: This else clause can be omitted because previous branches break early.
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Upload.js (20)
73-73: Do not use template literals if interpolation and special-character handling are not needed.
142-142: Change to an optional chain.
199-199: Change to an optional chain.
280-280: The computed expression can be simplified without the use of a string literal.
330-330: Use === instead of ==.
== is only allowed when comparing againstnull
437-437: Change to an optional chain.
459-475: Prefer for...of instead of forEach.
501-501: The computed expression can be simplified without the use of a string literal.
532-532: Change to an optional chain.
654-659: This else clause can be omitted because previous branches break early.
702-702: The computed expression can be simplified without the use of a string literal.
730-730: The computed expression can be simplified without the use of a string literal.
730-730: The computed expression can be simplified without the use of a string literal.
734-734: The computed expression can be simplified without the use of a string literal.
737-739: Prefer for...of instead of forEach.
738-738: The computed expression can be simplified without the use of a string literal.
738-738: The computed expression can be simplified without the use of a string literal.
738-738: The computed expression can be simplified without the use of a string literal.
740-740: The computed expression can be simplified without the use of a string literal.
744-744: The computed expression can be simplified without the use of a string literal.
Path-based Instructions (3)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Hypothesis.js (1)
Pattern
**/*.js: checkmicro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanPreview.js (1)
Pattern
**/*.js: checkmicro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Upload.js (1)
Pattern
**/*.js: check
Learnings (2)
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanPreview.js (1)
User: siddhant-nawale-egov PR: egovernments/DIGIT-Frontend#606 File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/utils/index.js:276-276 Timestamp: 2024-05-21T07:42:28.329Z Learning: The `addResourcesToFilteredDataToShow` function in `micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/utils/index.js` now includes checks for data integrity, such as validation of `previewData`, the common column, and `resources`, along with error logging for invalid data formats.micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Upload.js (2)
User: siddhant-nawale-egov PR: egovernments/DIGIT-Frontend#204 File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:0-0 Timestamp: 2024-03-13T05:11:36.400Z Learning: A more detailed message for file parsing errors in the `Upload.js` file is displayed elsewhere in the code, as clarified by the user.User: siddhant-nawale-egov PR: egovernments/DIGIT-Frontend#204 File: micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/pages/employee/Upload.js:468-481 Timestamp: 2024-03-13T07:33:45.211Z Learning: The error message in the `checkForErrorInUploadedFile` function within `Upload.js` is being localized and improved for better user experience, as clarified by the user.
micro-ui/web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/Hypothesis.js
Show resolved
Hide resolved
...web/micro-ui-internals/packages/modules/hcm-microplanning/src/components/MicroplanPreview.js
Show resolved
Hide resolved
No description provided.