BUGFIX|HCMPRE-1438: Updated payments Config key #2182
Conversation
📝 WalkthroughWalkthroughThe pull request introduces a series of changes across multiple files in the health payments module, primarily focusing on modifying the session storage key used for retrieving payment configurations. The key is changed from "paymentConfig" to "paymentsConfig" in several components, including BoundaryComponent, filter_section, BillInbox, and project_selection. Additionally, a new variable Changes
Sequence DiagramsequenceDiagram
participant UI as User Interface
participant SS as Session Storage
participant IS as Initialization Service
UI->>SS: Request payment configuration
SS-->>UI: Return configuration with new key "paymentsConfig"
UI->>IS: Fetch boundary data
IS->>IS: Determine hierarchyType
IS-->>UI: Return boundary information
Possibly related PRs
Suggested reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/components/BoundaryComponent.js(1 hunks)health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/components/attendance_inbox/filter_section.js(2 hunks)health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/components/bill_inbox/BillInbox.js(1 hunks)health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/pages/employee/project_selection.js(1 hunks)health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/services/PaymentsInitialization.js(2 hunks)
🧰 Additional context used
📓 Path-based instructions (5)
health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/components/BoundaryComponent.js (1)
Pattern **/*.js: check
health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/pages/employee/project_selection.js (1)
Pattern **/*.js: check
health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/components/attendance_inbox/filter_section.js (1)
Pattern **/*.js: check
health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/services/PaymentsInitialization.js (1)
Pattern **/*.js: check
health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/components/bill_inbox/BillInbox.js (1)
Pattern **/*.js: check
⏰ Context from checks skipped due to timeout of 10000ms (2)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (actions)
🔇 Additional comments (5)
health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/services/PaymentsInitialization.js (1)
118-118: LGTM!The hierarchyType parameter is correctly used in the boundary relationships search request.
health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/components/attendance_inbox/filter_section.js (1)
11-11: Verify the session storage key update across the codebase.The session storage key has been updated from "paymentConfig" to "paymentsConfig". This change appears to be part of a coordinated update across multiple files.
Let's verify that this change is consistent across the codebase and that there are no remaining instances of the old key:
Also applies to: 118-118
health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/pages/employee/project_selection.js (1)
30-30: Session storage key update is consistent.The update from "paymentConfig" to "paymentsConfig" matches the changes in other files.
health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/components/BoundaryComponent.js (1)
19-19: Session storage key update is consistent.The update from "paymentConfig" to "paymentsConfig" matches the changes in other files.
health/micro-ui/web/micro-ui-internals/packages/modules/health-payments/src/components/bill_inbox/BillInbox.js (1)
40-40: Session storage key update is consistent.The update from "paymentConfig" to "paymentsConfig" matches the changes in other files.
Let's verify the data migration for existing session storage:
✅ Verification successful
Session storage implementation is correct and consistent
The codebase exclusively uses the "paymentsConfig" key, with proper initialization in Module.js. No instances of the old key "paymentConfig" were found, indicating this is either a new feature or a clean implementation. No data migration is necessary.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any session storage initialization or migration logic echo "Searching for session storage initialization..." rg -A 5 "Digit\.SessionStorage\.set\(\"paymentsConfig\"" --type js # Search for any initialization service or configuration setup echo -e "\nSearching for configuration setup..." ast-grep --pattern 'const $_ = { $$$ paymentsConfig: $_, $$$ }'Length of output: 1026
Script:
#!/bin/bash # Search for old key usage echo "Searching for old key usage..." rg "Digit\.SessionStorage\.(get|set)\(\"paymentConfig\"" --type js # Search for any migration logic echo -e "\nSearching for migration logic..." rg -B 3 -A 3 "paymentConfig.*paymentsConfig" --type jsLength of output: 1550
...b/micro-ui-internals/packages/modules/health-payments/src/services/PaymentsInitialization.js
Show resolved
Hide resolved
Ramkrishna-egov
changed the title
Choose the appropriate template for your PR:
Feature PR
Feature Request
JIRA ID
Module
Description
Related Issues
Bugfix PR
Bugfix Request
JIRA ID
Module
Description
Root Cause
Related Issues
Release PR
Summary by CodeRabbit
Bug Fixes
New Features
hierarchyTypevariable in payments initialization service to improve configuration handling