Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE/HCMPRE-1776 : Added preview component basic screen #2102

Open
wants to merge 1 commit into
base: console
Choose a base branch
from

Conversation

Bhavya-egov
Copy link
Contributor

@Bhavya-egov Bhavya-egov commented Jan 6, 2025

Summary by CodeRabbit

  • New Features

    • Added a new AppPreview component to display a structured form with dynamic input fields
    • Introduced preview functionality in the Campaign Type selection screen
    • Enhanced styling for campaign-related UI elements
  • Style

    • Added new CSS classes for improved layout and design of campaign-related components
    • Implemented responsive design with flexible styling options

@Bhavya-egov Bhavya-egov requested a review from a team as a code owner January 6, 2025 06:58
Copy link
Contributor

coderabbitai bot commented Jan 6, 2025

📝 Walkthrough

Walkthrough

This pull request introduces a new AppPreview component for the campaign management module. The changes include adding a new React component in the campaign-manager module, registering it in the module's configuration, and creating corresponding CSS styles. The new component provides a dynamic form rendering mechanism with support for various input types, including a specialized date of birth picker. A preview popup feature is also added to the CampaignType component to display the new AppPreview interface.

Changes

File Change Summary
health/micro-ui/.../css/src/pages/employee/campaign.scss Added three new CSS classes: .date-style, .app-preview, and .mobile-top for enhanced styling
health/micro-ui/.../campaign-manager/src/Module.js Imported and registered new AppPreview component
health/micro-ui/.../campaign-manager/src/components/AppPreview.js Created new React component with dynamic form rendering and DobPicker sub-component
health/micro-ui/.../campaign-manager/src/components/CampaignType.js Added showPopUp1 state and preview popup functionality with AppPreview component

Sequence Diagram

sequenceDiagram
    participant User
    participant CampaignType
    participant AppPreview
    
    User->>CampaignType: Click Preview Button
    CampaignType->>CampaignType: Set showPopUp1 to true
    CampaignType->>AppPreview: Render Preview Component
    AppPreview-->>User: Display Dynamic Form
    User->>CampaignType: Close Popup
    CampaignType->>CampaignType: Set showPopUp1 to false
Loading

Possibly related PRs

Suggested reviewers

  • nipunarora-eGov
  • Swathi-eGov

Poem

🐰 A Rabbit's Ode to Preview Magic

In pixels bright, a form takes flight,
With dynamic fields of pure delight,
CSS classes dancing free,
A campaign's preview, just for me!

Hop, hop, hooray! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0b3dee9 and 486c4c2.

📒 Files selected for processing (4)
  • health/micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/campaign.scss (1 hunks)
  • health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/Module.js (2 hunks)
  • health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/AppPreview.js (1 hunks)
  • health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignType.js (3 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/Module.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignType.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/AppPreview.js (1)

Pattern **/*.js: check

🪛 Biome (1.9.4)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/CampaignType.js

[error] 176-176: Avoid passing children using a prop

The canonical way to pass children in React is to use JSX elements

(lint/correctness/noChildrenProp)


[error] 184-192: Missing key property for this element in iterable.

The order of the items may change, and having a key can help React identify which item was moved.
Check the React documentation.

(lint/correctness/useJsxKeyInIterable)

🔇 Additional comments (5)
health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/components/AppPreview.js (2)

1-4: Imports are well-structured.
The current set of imports from react, @egovernments/digit-ui-components, and react-i18next looks appropriate. No issues found regarding unused imports or naming inconsistencies.


106-121: DOB picker fields are always disabled.
Currently, the "Years" and "Months" inputs are disabled. If you plan to enable them in the future or calculate them based on the date input, consider implementing appropriate state logic to keep these fields in sync.

health/micro-ui/web/micro-ui-internals/packages/modules/campaign-manager/src/Module.js (2)

60-60: Properly importing the new component.
Import statement for AppPreview is correct and well-organized. No concerns here.


179-179: Registration of AppPreview is seamless.
Including AppPreview in componentsToRegister is consistent with the existing pattern. This correctly exposes the component for dynamic loading.

health/micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/campaign.scss (1)

239-244: Good usage of flex layout.
.date-style nicely organizes DOB fields with a flex display. Ensure the container is responsive across various screen sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant