Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE/SN-368 : Workbench module enahancement to have auto localisation creation for mdms data create #2058

Merged
merged 31 commits into from
Jan 6, 2025
Merged

FEATURE/SN-368 : Workbench module enahancement to have auto localisation creation for mdms data create #2058

Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
d7478d9
localization fixes
mithunhegde-egov Dec 12, 2024
3d63498
localization fixes
mithunhegde-egov Dec 12, 2024
5ac73ac
updated
mithunhegde-egov Dec 13, 2024
d8c9125
localization changes
mithunhegde-egov Dec 15, 2024
461ae73
mdms edit updated
mithunhegde-egov Dec 16, 2024
608064d
keystroke fix
mithunhegde-egov Dec 16, 2024
c30ba57
css fixes
mithunhegde-egov Dec 18, 2024
745974e
inter package json updated
mithunhegde-egov Dec 18, 2024
9d68cf4
ui cusotmization
mithunhegde-egov Dec 18, 2024
5ba8d41
cleanup console
mithunhegde-egov Dec 18, 2024
62cf267
removed console log
mithunhegde-egov Dec 18, 2024
680d8e8
updated mdms edit
mithunhegde-egov Dec 18, 2024
c0d0d45
cleanup console log
mithunhegde-egov Dec 18, 2024
f3f7561
Merge branch 'develop' into SN368-localizationfixes
mithunhegde-egov Dec 18, 2024
60650ad
console cleanup
mithunhegde-egov Dec 18, 2024
a8a7f8c
cleanup console
mithunhegde-egov Dec 18, 2024
fd93e5a
review changes
mithunhegde-egov Dec 19, 2024
d2cc13a
review fixes
mithunhegde-egov Dec 20, 2024
8cc5498
css version updated
mithunhegde-egov Dec 20, 2024
ce10d23
Apply suggestions from code review
jagankumar-egov Dec 20, 2024
ad7a49d
index.html css version corrected
mithunhegde-egov Dec 20, 2024
9a32b78
Apply suggestions from code review
jagankumar-egov Dec 20, 2024
6e90017
css version changed in index.html
mithunhegde-egov Dec 23, 2024
70ab85d
Merge branch 'FEATURE/SN-368' of https://github.com/egovernments/DIGI…
mithunhegde-egov Dec 23, 2024
e7b8f33
css updated and review changes
mithunhegde-egov Dec 23, 2024
600601a
review changes
mithunhegde-egov Dec 24, 2024
eb9cf9a
resolved conflict
mithunhegde-egov Jan 6, 2025
fbae350
added comments back
mithunhegde-egov Jan 6, 2025
d8dfe5a
Update micro-ui/web/micro-ui-internals/packages/modules/workbench/src…
jagankumar-egov Jan 6, 2025
9eaaa13
coderabbit changes
mithunhegde-egov Jan 6, 2025
f8512a4
Merge branch 'FEATURE/SN-368' of https://github.com/egovernments/DIGI…
mithunhegde-egov Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions micro-ui/web/core/inter-package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"resolutions": {
"**/@babel/runtime": "7.20.1",
"**/babel-preset-react-app": "10.0.0",
"**/@babel/traverse":"7.25.9",
"**/ajv": "8.11.2",
"fast-uri":"2.1.0"
},
Expand Down
1 change: 1 addition & 0 deletions micro-ui/web/micro-ui-internals/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
"resolutions": {
"**/@babel/runtime": "7.20.1",
"**/babel-preset-react-app": "10.0.0",
"**/@babel/traverse":"7.25.9",
"**/styled-components": "5.0.0",
"fast-uri":"2.1.0"
},
Expand Down
2 changes: 1 addition & 1 deletion micro-ui/web/micro-ui-internals/packages/css/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@egovernments/digit-ui-css",
"version": "1.8.10",
"version": "1.8.11",
"license": "MIT",
"main": "dist/index.css",
"author": "Jagankumar <[email protected]>",
Expand Down
56 changes: 55 additions & 1 deletion micro-ui/web/micro-ui-internals/packages/css/src/digitv2/pages/employee/workbench.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,4 +1047,58 @@ user-select: none;
.diff-code-insert {
background-color: #eaffee;
}
}

}


.code-details {
padding: 0.5rem 1.5rem;
background-color: #f9f9f9;
border: 0.125rem solid #e0e0e0;
border-radius: 0.25rem;
}

.code-row {
display: flex;
align-items: flex-start;
margin-bottom: 0.75rem;

&:last-child {
margin-bottom: 0;
}
}

.code-key {
flex: 0 0 9rem;
font-size: 0.9rem;
font-weight: bold;
color: #444;
text-align: left;
line-height: 1.2rem;
}

.code-value-container {
display: flex;
flex-direction: column;
flex: 1;
margin-left: 0.5rem;
align-items: flex-start;
}

.code-value {
font-size: 0.9rem;
color: #555;
line-height: 1.2rem;
}
Comment on lines +1054 to +1092
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

LGTM! Well-structured component styles with good organization.

The code details component styles are well-organized with a clear hierarchy and meaningful class names. The use of rem units for measurements and semantic color values is consistent with best practices.

A few suggestions to enhance maintainability:

  1. Consider extracting color values into SCSS variables
  2. Add comments to document the component's structure
+ // Code details component - Displays key-value pairs in a structured layout
 .code-details {
   padding: 0.5rem 1.5rem;
-  background-color: #f9f9f9;
-  border: 0.125rem solid #e0e0e0;
+  background-color: var(--code-details-bg, #f9f9f9);
+  border: 0.125rem solid var(--code-details-border, #e0e0e0);
   border-radius: 0.25rem;
 }

 .code-row {
   display: flex;
   align-items: flex-start;
   margin-bottom: 0.75rem;

   &:last-child {
     margin-bottom: 0;
   }
 }

 .code-key {
   flex: 0 0 9rem; 
   font-size: 0.9rem;
   font-weight: bold;
-  color: #444;
+  color: var(--code-key-color, #444);
   text-align: left;
   line-height: 1.2rem;
 }

 .code-value {
   font-size: 0.9rem;
-  color: #555;
+  color: var(--code-value-color, #555);
   line-height: 1.2rem;
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.code-details {
padding: 0.5rem 1.5rem;
background-color: #f9f9f9;
border: 0.125rem solid #e0e0e0;
border-radius: 0.25rem;
}
.code-row {
display: flex;
align-items: flex-start;
margin-bottom: 0.75rem;
&:last-child {
margin-bottom: 0;
}
}
.code-key {
flex: 0 0 9rem;
font-size: 0.9rem;
font-weight: bold;
color: #444;
text-align: left;
line-height: 1.2rem;
}
.code-value-container {
display: flex;
flex-direction: column;
flex: 1;
margin-left: 0.5rem;
align-items: flex-start;
}
.code-value {
font-size: 0.9rem;
color: #555;
line-height: 1.2rem;
}
// Code details component - Displays key-value pairs in a structured layout
.code-details {
padding: 0.5rem 1.5rem;
background-color: var(--code-details-bg, #f9f9f9);
border: 0.125rem solid var(--code-details-border, #e0e0e0);
border-radius: 0.25rem;
}
.code-row {
display: flex;
align-items: flex-start;
margin-bottom: 0.75rem;
&:last-child {
margin-bottom: 0;
}
}
.code-key {
flex: 0 0 9rem;
font-size: 0.9rem;
font-weight: bold;
color: var(--code-key-color, #444);
text-align: left;
line-height: 1.2rem;
}
.code-value-container {
display: flex;
flex-direction: column;
flex: 1;
margin-left: 0.5rem;
align-items: flex-start;
}
.code-value {
font-size: 0.9rem;
color: var(--code-value-color, #555);
line-height: 1.2rem;
}













jagankumar-egov marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 1 addition & 1 deletion micro-ui/web/micro-ui-internals/packages/modules/sandbox/src/configs/UICustomizations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,4 +269,4 @@ export const UICustomizations = {
}
},
},
};
};
Loading