Demo2 issue fixes

[rachana-egov]

Summary by CodeRabbit

Release Notes

• New Features

  • Enhanced pagination options in multiple components, allowing users to select from [10, 20, 50, 100] rows per page.
  • Added toast notifications to provide user feedback on actions in the PopInbox component.

• Improvements

  • Streamlined the WorkflowCommentPopUp by integrating button functionalities directly within the popup.
  • Improved accessibility and security components to track changes and manage save button states effectively.
  • Increased initial rows per page in the PopInbox component from 5 to 50 for better user experience.

• Bug Fixes

  • Corrected state management for various components to ensure accurate data handling and user interactions.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

📝 Walkthrough

Walkthrough

The changes in this pull request involve multiple components within the microplan module, focusing on pagination functionality, state management, and user feedback mechanisms. Key modifications include updates to pagination options in FacilityPopup.js and PopInboxTable.js, the introduction of change detection logic in AccessibilityPopUp.js and SecurityPopUp.js, and the removal of toast notifications in WorkflowCommentPopUp.js. Additionally, the PopInbox.js component has been enhanced to manage toast notifications and update pagination settings. Overall, the changes aim to refine user interactions and improve data handling across the components.

Changes

File Path	Change Summary
.../FacilityPopup.js	Adjusted handling of planEmployeeDetailsData and simplified pagination structure in censusSearch. Updated paginationRowsPerPageOptions from [10, 20, 30, 40, 50] to [10, 20, 50, 100].
.../PopInboxTable.js	Updated paginationDefaultPage to reflect props?.currentPage. Changed paginationRowsPerPageOptions from [5, 10, 15, 20, 25] to [10, 20, 50, 100].
.../WorkflowCommentPopUp.js	Removed toast notification management; integrated success/error handling directly in mutation callbacks. Restructured return statement to include PopUp properties directly.
.../accessbilityPopUP.js	Introduced initialValues state and isChanged function to track dropdown value changes. Updated useEffect to set initial values from census.additionalDetails.accessibilityDetails.
.../securityPopUp.js	Added initialAnswers state and isChanged function for tracking changes to security details. Updated useEffect to set initialAnswers from census.additionalDetails.securityDetails.
.../employee/PopInbox.js	Added Toast import and showToast state. Updated rowsPerPage from 5 to 50. Modified logic for assignee field and useEffect dependencies. Updated commentPath prop in WorkflowCommentPopUp.

Possibly related PRs

• User management screen #1496: Related pagination updates in FacilityPopup.js and PopInboxTable.js.
• Simple view village screen with static popup #1548: Pagination functionality enhancements in PopInboxTable.js align with changes in FacilityPopup.js.
• Pop inbox screen #1588: Pagination updates in PopInbox.js connect with modifications in FacilityPopup.js.
• added jurisdictions in facility serach and updated popinbox #1602: Changes in PopInbox.js regarding pagination and census data handling relate to updates in FacilityPopup.js.
• Added action bar for pop inbox screen #1622: Addition of showEditColumn prop in PopInboxTable.js is relevant to changes in FacilityPopup.js.
• Added condition based rendering of edit column #1657: Conditional rendering of the edit column in PopInboxTable.js is directly related to changes in FacilityPopup.js.

Suggested reviewers

• nipunarora-eGov

Poem

🐰 In the meadow where we play,
Changes come to brighten the day.
With pop-ups and tables, oh so fine,
Pagination dances in a line.
Toasts now sing with joy anew,
Hopping forward, we bid adieu! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 10

🧹 Outside diff range comments (4)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/securityPopUp.js (1)

Line range hint 99-116: Enhance accessibility for radio buttons.

While the className fix is good, consider adding aria-labels to improve accessibility.

Consider these improvements:

   <RadioButtons
     isMandatory={q.required}
+    aria-label={`Security question ${q.id}: ${q.question}`}
     options={q.values?.map(item => ({
       code: item,
       value: item,
     }))}
     optionsKey="code"
     selectedOption={answers[q.id]}
     style={{
       display: "flex",
       flexDirection: "column",
       gap: "1rem",
     }}
     onSelect={(value) => handleOptionChange(q.id, value)}
   />

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/accessbilityPopUP.js (1)

Line range hint 1-1: Fix file naming convention.

The file name accessbilityPopUP.js has inconsistent casing and a typo. React components typically use PascalCase for file names.

Rename the file to:

• AccessibilityPopup.js or
• AccessibilityPopUp.js

Also, note the typo: "accessbility" should be "accessibility"

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/WorkflowCommentPopUp.js (1)

Line range hint 1-158: Consider enhancing error handling for API failures.

While the component handles form validation errors well, the API error handling could be improved to provide better feedback to users.

Consider adding a more robust error handling mechanism:

const handleSave = async () => {
    if (!comment.trim()) {
        setError(true);
        return;
    }

    try {
        setIsSubmitting(true);
        const updatedPayload = setCommentInPayloadForList({ ...requestPayload }, commentPath, comment);
        
        await mutation.mutate(
            {
                body: updatedPayload
            },
            {
                onSuccess: (data) => {
                    onSuccess?.(data);
                    setComment(""); // Clear comment on success
                },
                onError: (error) => {
                    onError?.(error);
                    // Provide specific error feedback based on error type
                    const errorMessage = error.response?.data?.message || 'Failed to save comment';
                    setError(errorMessage);
                }
            }
        );
    } catch (error) {
        console.error('Error saving comment:', error);
        setError('An unexpected error occurred');
    } finally {
        setIsSubmitting(false);
    }
};

🧰 Tools

🪛 Biome

[error] 113-113: Avoid passing children using a prop

The canonical way to pass children in React is to use JSX elements

(lint/correctness/noChildrenProp)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

Line range hint 437-450: Consider extracting common WorkflowCommentPopUp configuration.

The error handling logic is duplicated between the two WorkflowCommentPopUp instances. Consider extracting common configuration into a reusable hook or utility.

// Create a custom hook
const useWorkflowUpdate = (onSuccess) => {
  const { t } = useTranslation();
  return {
    commentPath: "workflow.comments",
    onSuccess,
    onError: (data) => {
      const errorMessage = error?.response?.data?.Errors?.[0]?.code 
        || error?.message 
        || 'WORKFLOW_UPDATE_ERROR';
      setShowToast({ 
        key: "error", 
        label: t(errorMessage),
        transitionTime: 5000 
      });
    }
  };
};

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 34b5150 and d2436c2.

📒 Files selected for processing (6)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FacilityPopup.js (4 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/PopInboxTable.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/WorkflowCommentPopUp.js (1 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/accessbilityPopUP.js (3 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/securityPopUp.js (4 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (7 hunks)

🧰 Additional context used

📓 Path-based instructions (6)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FacilityPopup.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/PopInboxTable.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/WorkflowCommentPopUp.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/accessbilityPopUP.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/securityPopUp.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

Pattern **/*.js: check

🪛 Biome

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/WorkflowCommentPopUp.js

[error] 113-113: Avoid passing children using a prop

The canonical way to pass children in React is to use JSX elements

(lint/correctness/noChildrenProp)

🔇 Additional comments (10)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/securityPopUp.js (1)

142-142: LGTM! Good handling of button states.

The save button's disabled state correctly considers both the change status and loading state, preventing unnecessary API calls and providing good user feedback.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/accessbilityPopUP.js (1)

15-15: LGTM: Clean state initialization.

The addition of initialValues state follows React best practices and is well-placed with other state declarations.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/WorkflowCommentPopUp.js (1)

137-156: LGTM! Good implementation of button states.

The implementation of disabling buttons during submission is a good practice to prevent duplicate submissions. The use of isSubmitting state for both buttons ensures a consistent user experience.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (3)

223-223: LGTM! Dependencies and state handling are correct.

The useEffect dependencies are properly updated, and the new effect correctly manages tab visibility based on the validation state.

Also applies to: 229-229, 232-235

---

452-459: LGTM! Toast implementation is correct.

The Toast component is properly implemented with appropriate props and visibility handling.

---

29-31: Verify the impact of increased default page size.

Increasing the default rowsPerPage from 5 to 50 could impact initial load performance and user experience. Consider:

• Initial data fetch time with larger payload
• Mobile device rendering performance
• Server-side resource utilization

✅ Verification successful

Based on the search results, I can now provide a final response since I have sufficient context about pagination implementation across the codebase:

Default page size of 50 is aligned with system design

The increased default page size from 5 to 50 rows is actually consistent with the codebase's pagination patterns:

1. The Table component supports page sizes of [10, 20, 30, 40, 50] as standard options
2. Multiple other components/modules use similar or even larger default page sizes:
   • Campaign manager uses 50-100 records
   • Document search uses 50 records
   • MDMS search uses 50-200 records
   • Project search uses 50-100 records

The change aligns with these established patterns and the UI is already optimized to handle this page size through:

• Server-side pagination support
• Proper limit/offset handling in API calls
• Configurable page size options allowing users to adjust if needed

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any performance-related configurations or pagination limits
rg -g '*.{js,json}' -A 5 'rowsPerPage|pageSize|limit' 

Length of output: 189001

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/FacilityPopup.js (4)

73-74: LGTM! Improved code formatting.

The role array formatting changes enhance readability while maintaining the same functionality.

---

142-145: LGTM! Improved pagination structure.

The pagination parameters have been correctly restructured at the root level, and the conditional logic for areaCodes is properly separated.

---

351-351: Formatting improvement noted.

---

413-414: 🧹 Nitpick (assertive)

Verify UX impact of new pagination options.

While the changes align with PopInboxTable.js for consistency, please verify that:

1. The larger page sizes (50, 100) don't cause performance issues with data loading
2. The UI remains responsive when displaying larger datasets
3. Users are comfortable with these specific page size options

Consider implementing:

1. Loading states for larger page sizes
2. Progressive loading for better performance
3. Monitoring of user preferred page sizes to validate these options