-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing workbench deployement #163
Conversation
WalkthroughWalkthroughThe recent updates focus on renaming elements within the webpack production configurations for a micro-UI web project. Specifically, the entry point and module federation identifiers for what was known as Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- micro-ui/web/packages/core/webpack.prod.js (1 hunks)
- micro-ui/web/packages/workbench/webpack.prod.js (1 hunks)
Additional comments: 3
micro-ui/web/packages/workbench/webpack.prod.js (2)
- 10-10: The
publicPath
has been updated from"/workbench/"
to"workbench-web"
. Ensure this change aligns with the deployment directory structure and asset referencing throughout the application. This adjustment is crucial for the correct location of deployed assets at runtime.- 15-15: The
name
property in the ModuleFederationPlugin configuration has been changed from"workbench"
to"workbench-web"
. This change is essential for consistent module identification across the application. Verify that this new name does not conflict with existing modules or naming conventions within the micro-UI architecture.micro-ui/web/packages/core/webpack.prod.js (1)
- 24-24: The entry point for the
workbench
module has been renamed toworkbench-web
. This change is crucial for avoiding naming conflicts and ensuring correct module federation. Verify that all references to the workbench module throughout the application have been updated to reflect this new name.
Summary by CodeRabbit