Fixed filter card issue and added check to show validate action only

[rachana-egov]

Summary by CodeRabbit

• New Features

  • Improved state management in the InboxFilterWrapper for better handling of default values and filter resets.
  • Enhanced loading state display in the PopInbox component for a smoother user experience.

• Bug Fixes

  • Refined logic to prevent unnecessary updates and ensure correct filter application in the PopInbox component.
  • Removed console log statements to streamline debugging output.

These changes enhance the user interface's responsiveness and overall functionality.

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The pull request introduces modifications to the InboxFilterWrapper and PopInbox components. The InboxFilterWrapper component's state management for selectedValue has been refined to prevent unnecessary updates, and the clearFilters function now maintains the selection state. In the PopInbox component, console log statements were removed, and the logic for handling selected filters has been improved. Additionally, loading state handling and action mapping have been adjusted to enhance user interface responsiveness.

Changes

File	Change Summary
.../InboxFilterWrapper.js	Refined selectedValue state management, updated clearFilters to maintain selection, modified selectedOption prop for RadioButtons, enhanced createArrayFromObject function.
.../PopInbox.js	Removed console log, refined filter logic in clearFilters, updated defaultValue condition, adjusted loading state handling, and modified action mapping in the table.

Possibly related PRs

• Update Inbox Filter Wrapper to support count #1562: This PR updates the InboxFilterWrapper component, which is directly related to the changes made in the main PR, specifically regarding the state management of selectedValue and the createArrayFromObject function.
• Inbox Filter Wrapper added #1560: This PR introduces the InboxFilterWrapper component, which is the same component being modified in the main PR, establishing a foundational connection to the changes made.

Suggested reviewers

• nipunarora-eGov
• Swathi-eGov

Poem

In the garden where filters grow,
A rabbit hops to and fro.
"With clear paths and choices bright,
Our inbox shines, a pure delight!"
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between bc9386e and cce5a56.

📒 Files selected for processing (1)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (7 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

Pattern **/*.js: check

🔇 Additional comments (6)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (6)

120-122: LGTM: Implemented action hiding as suggested.

The actionsToHide array effectively filters out actions containing "EDIT" from actionsMain. This implementation aligns with the suggestion from the previous review to create a map for actions to hide.

---

150-150: LGTM: Reset villages selection on data or filter change.

The addition of setVillagesSelected(0) ensures that the selected villages count is reset whenever new data is loaded or filters are changed. This prevents stale selection states and improves user experience.

---

167-168: LGTM: Optimized filter clearing logic.

The modification to clearFilters now checks if the current selectedFilter is different from the default before updating. This optimization prevents unnecessary state updates and reduces redundant renders, improving the component's performance.

---

202-203: LGTM: Improved default filter logic.

The modification to the defaultValue prop ensures that the default filter is only applied when it matches the first entry in activeFilter. This change provides more precise control over the initial filter state, improving the consistency of the filter behavior.

---

Line range hint 240-253: LGTM: Implemented action hiding and improved loading state handling.

These changes bring two significant improvements:

1. The rendering of action buttons now filters out actions present in the actionsToHide array, implementing the action hiding feature as intended.
2. A loader is displayed when isFetching is true, improving the user experience during data retrieval.

These modifications enhance both the functionality and user interface of the component.

---

Line range hint 1-262: Overall assessment: Improvements in functionality and performance

The changes in this file successfully address the PR objectives and previous review comments. Key improvements include:

1. Implementation of action hiding functionality.
2. Optimization of filter clearing and default filter logic.
3. Enhanced loading state handling.
4. Reset of selected villages on data or filter changes.

These modifications contribute to a more efficient and user-friendly component. The code quality has been maintained, and no significant issues were introduced.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range comments (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js (1)

Line range hint 27-34: Enhanced robustness of createArrayFromObject function

The changes to the createArrayFromObject function improve its robustness by handling edge cases and preventing potential runtime errors. Good job on adding these checks!

For improved readability, consider extracting the condition into a separate variable:

const isValidInput = obj && typeof obj === "object" && Object.keys(obj).length > 0 && typeof t === "function";
if (!isValidInput) {
  return [];
}
// Rest of the function...

This change would make the condition more self-explanatory and easier to maintain.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 4594453 and bc9386e.

📒 Files selected for processing (2)

• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js (3 hunks)
• health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (7 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js (1)

Pattern **/*.js: check

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (1)

Pattern **/*.js: check

📓 Learnings (1)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js (1)

Learnt from: Ramkrishna-egov
PR: egovernments/DIGIT-Frontend#1562
File: health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js:57-57
Timestamp: 2024-10-18T08:50:44.006Z
Learning: In the `InboxFilterWrapper` component, `optionsKey` should always be set to `"name"` because options are transformed and created within the component.

🔇 Additional comments (9)

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/components/InboxFilterWrapper.js (3)

16-25: Improved state management in useEffect hook

The changes in the useEffect hook enhance the component's behavior:

1. It now only updates selectedValue when props.defaultValue is defined and contains keys, preventing unnecessary updates.
2. Adding t to the dependency array ensures that changes in translations will trigger the effect, maintaining consistency with the latest translations.

These improvements make the component more robust and efficient.

---

54-57: Verify the intention of clearFilters function

The clearFilters function now sets selectedValue to its current state instead of clearing it. This change maintains the selection state when the clear action is invoked, which might not be the expected behavior for a "clear filters" action.

Could you clarify the intention behind this change? If the goal is to maintain the current selection, consider renaming the function to better reflect its purpose (e.g., resetFilters). If the intention is to clear the selection, you might want to revert to setting selectedValue to null:

const clearFilters = () => {
  setSelectedValue(null); // Clear the selection
  if (props.clearFilters) {
    props.clearFilters();
  }
};

Please confirm the desired behavior for this function.

---

76-76: Improved prop passing in RadioButtons component

The change to use selectedValue?.code instead of selectedValue for the selectedOption prop is a good improvement. This ensures that only the code of the selected option is passed for comparison, which:

1. Aligns better with the component's internal structure.
2. Improves consistency in option selection.
3. Prevents potential issues if the full selectedValue object was being used for comparison.

This change enhances the reliability of the radio button selection mechanism.

health/micro-ui/web/micro-ui-internals/packages/modules/microplan/src/pages/employee/PopInbox.js (6)

64-64: LGTM: Improved code readability

The added empty line enhances code readability by separating different logical sections.

---

Line range hint 120-147: LGTM: Improved filtering functionality

The changes enhance the filtering functionality by incorporating the selected filter into the API request and properly handling cases when no filter is selected. The useEffect hook now correctly sets the default filter when necessary.

---

164-165: LGTM: Improved clearFilters function

The modification to the clearFilters function ensures that the filter is only reset when necessary, improving the overall functionality of the component.

---

199-201: LGTM: Improved consistency in filter behavior

The modification to the defaultValue prop ensures consistent behavior with the clearFilters function, only setting the default value when necessary.

🧰 Tools

🪛 Biome

[error] 194-201: JSX elements without children should be marked as self-closing. In JSX, it is valid for any element to be self-closing.

Unsafe fix: Use a SelfClosingElement instead

(lint/style/useSelfClosingElements)

---

250-250: LGTM: Improved user experience with loader

The addition of a loader when isFetching is true improves the user experience by providing visual feedback during data loading.

---

Line range hint 237-243: Verify the intention behind filtering out "EDIT" actions

The code now filters out actions that include "EDIT". Please confirm if this is the intended behavior, as it may impact the available actions for users.

Run the following script to check for any references to "EDIT" actions in the codebase:

[nipunarora-eGov]

Change actions hiding logic