-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
card order and link order #1443
Changes from 7 commits
faf1aae
33e609d
efad487
27deece
aafe8d7
57871d8
73aaf69
9c183a5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
export const orderConfig={ | ||
"order": { | ||
"cardorder": { | ||
mithunhegde-egov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"HRMS": 1, | ||
"PGR": 2 | ||
}, | ||
"linkorder": { | ||
"HRMS": { | ||
"HRMS_Create_Employee": 1, | ||
"HRMSInbox": 2, | ||
"Configure_master": 3 | ||
}, | ||
"PGR": { | ||
"Create_Complaints": 1, | ||
"ComplaintsInbox": 2, | ||
"Configure_master": 3 | ||
} | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Well-organized The Consider the following improvements:
These enhancements would make the system more adaptable to changing requirements without necessitating code modifications. |
||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle
null
values in link sorting to ensure consistent ordering.When
orderA
ororderB
arenull
, subtracting them can lead to unintended sorting behavior. Consider defaulting these values toNumber.MAX_SAFE_INTEGER
, similar to how it's handled in module sorting. This ensures that links without a specified order are placed at the end.Apply this diff to adjust the handling of
null
values:📝 Committable suggestion