Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing + to plotting code #3

Closed
wants to merge 1 commit into from
Closed

Add missing + to plotting code #3

wants to merge 1 commit into from

Conversation

teunbrand
Copy link

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break irt.

While I'm not sure why the error we observed is new, the cause seems to be simply a missing + somewhere in the plotting code, so that is what this PR aims to fix.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help irt get out a fix if necessary.

@teunbrand
Copy link
Author

This is a friendly reminder that the release of ggplot2 is scheduled soon.

@teunbrand
Copy link
Author

Considering this fixed by 4b70d8f and thereby closing this PR.

@teunbrand teunbrand closed this Jul 7, 2024
@teunbrand teunbrand deleted the ggplot2_3.5.0 branch July 7, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant