Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for CONTRIBUTING.md file #29

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

tunnckoCore
Copy link
Contributor

fixes #25

Signed-off-by: Charlike Mike Reagent <[email protected]>
@tunnckoCore
Copy link
Contributor Author

tunnckoCore commented Jun 4, 2018

side note: damn... CircleCI is freakin instant, still surprising me. No matter what, i won't move from Github and CircleCI until someone beat them. 🤣

@zephraph
Copy link
Contributor

zephraph commented Jun 6, 2018

Hmm... so what happens if there's a contributing file, but it doesn't have a maidfile comment... does it move on to the readme?

@tunnckoCore
Copy link
Contributor Author

Mmm.. not sure.

@egoist
Copy link
Owner

egoist commented Jun 6, 2018

it doesn't 😅

@tunnckoCore
Copy link
Contributor Author

Probably ;d If we put it after the readme? Will it work that way or?

I'm more in flavor to PR for #4 which requires rethinking of those files and ideas - we should support only maidfile.md and optionally another files through the --path flag. I actually implemented it, but there are another problems for which i'll open new issue to discuss (related to passing flags to tasks which in some cases is pretty not comfortable).

@jakepearson jakepearson merged commit 00be599 into egoist:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support /CONTRIBUTING\.md/i file?
4 participants