Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: return false explicitly #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: return false explicitly #7

wants to merge 1 commit into from

Conversation

m-shaka
Copy link

@m-shaka m-shaka commented Feb 3, 2023

Hi.
Now await hasGlobalInstallation(...) returns true or raise an error.
I think it's better to return false

@m-shaka m-shaka mentioned this pull request Feb 6, 2023
Merged
@typedarray
Copy link

Strongly agree with this change. At the moment, if detect cannot find a lockfile (happens often in monorepos), it will throw an error if either yarn or pnpm are not installed.

@egoist, anything I can do to help get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-shaka @typedarray