Improvements to parameter passing #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 4, 2020
ComponentParameterBuilder should allow adding cascading values even if not used directly by CUT
#178
Closed
egil
force-pushed
the
param-builder-fixes
branch
from
ab28505
to
cc1b1cc
Compare
Codecov Report
@@ Coverage Diff @@
## dev #203 +/- ##
==========================================
+ Coverage 78.08% 79.13% +1.05%
==========================================
Files 102 102
Lines 2961 2929 -32
Branches 374 373 -1
==========================================
+ Hits 2312 2318 +6
+ Misses 523 486 -37
+ Partials 126 125 -1
Continue to review full report at Codecov.
|
…o component parameter factory
egil
force-pushed
the
param-builder-fixes
branch
from
0ef62ae
to
ee39242
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
egil
added a commit
that referenced
this pull request
Oct 1, 2020
* componentparametercollection * Support for passing multiple template and render fragments * Automated dotnet-format update * cascading values * Finished component parameter collection, closed #142, updated tests to component parameter factory * Fixed null warnings * Automated dotnet-format update * Fixes for CodeQL warnings * Added ChildContent and RenderFragment tests * Added support for passing template fragments * Removed ComponentParameterBuilder, added support for unmatched and cascading values * Switched to C# 9 compile * Automated dotnet-format update * unnamed cascading value with add * Removed .net move hack from workflows * Fix for null errors * Automated dotnet-format update * Added extra factory method and moved ComponentParameter out into Bunit namespace * Updated docs with new parameter passing logic * Automated dotnet-format update * Updated changelog Co-authored-by: Github Actions <[email protected]>
egil
added a commit
that referenced
this pull request
Oct 2, 2020
…ith an html5 tag implemented (#220) * reset changelog with unreleased section * Cleanup using and resorted them * Improvements to parameter passing in c# based tests (#203) * componentparametercollection * Support for passing multiple template and render fragments * Automated dotnet-format update * cascading values * Finished component parameter collection, closed #142, updated tests to component parameter factory * Fixed null warnings * Automated dotnet-format update * Fixes for CodeQL warnings * Added ChildContent and RenderFragment tests * Added support for passing template fragments * Removed ComponentParameterBuilder, added support for unmatched and cascading values * Switched to C# 9 compile * Automated dotnet-format update * unnamed cascading value with add * Removed .net move hack from workflows * Fix for null errors * Automated dotnet-format update * Added extra factory method and moved ComponentParameter out into Bunit namespace * Updated docs with new parameter passing logic * Automated dotnet-format update * Updated changelog Co-authored-by: Github Actions <[email protected]> * Updated version to beta-11 * Context finder for strings that start with an html5 tag * Fix for build error * Added support for HTML, HEAD, and BODY, stopped reusing element contexts * Cleanup usings Co-authored-by: Github Actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of bugs around passing parameters to components in c# based tests, and adds a few extra features.
PR meta checklist
DEVbranch.Content checklist
Issues